Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box #42523

Closed
1 of 6 tasks
m-natarajan opened this issue May 23, 2024 · 48 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented May 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.75-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4569546
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Open any report
  3. Type random letters in compose

Expected Result:

User must be able to type in compose.

Actual Result:

User unable to type in compose. Compose is not functioning properly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489326_1716464220773.Screenrecorder-2024-05-23-17-03-59-903.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 23, 2024
Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 23, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 23, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

  1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
    • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
  2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
    • You can adjust the urgency of the issue to better represent the gravity of the bug.
    • If the issue is super low priority, feel free to un-assign yourself.
    • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
    • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

@melvin-bot melvin-bot bot removed the Hourly KSv2 label May 23, 2024
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels May 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #vip-vsb

@amyevans
Copy link
Contributor

I'm unable to reproduce:

screen-20240523-120314.mp4

@adelekennedy can you give it a try?

@amyevans amyevans removed the DeployBlocker Indicates it should block deploying the API label May 23, 2024
@amyevans
Copy link
Contributor

Removed the DeployBlocker label because it's for sure not a backend issue

@samilabud
Copy link
Contributor

samilabud commented May 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

mweb-chat-Unable to type in compose box

What is the root cause of that problem?

It seems the new module "@expensify/react-native-live-markdown" is the root cause, when we pass it through our RNMarkDownTextInput component (markdownStyle={markdownStyle}):

<RNMarkdownTextInput
autoComplete="off"
autoCorrect={!Browser.isMobileSafari()}
placeholderTextColor={theme.placeholderText}
ref={(el) => (textInput.current = el)}
selection={selection}
style={[inputStyleMemo]}
markdownStyle={markdownStyle}
value={value}

What changes do you think we should make in order to solve the problem?

As the @expensify/react-native-live-markdown component is out of our control (externals) I suggest marking it as internal, meanwhile we can use the RNMarkDownTextInput without the new markdown styles, like:

<RNMarkdownTextInput
                autoComplete="off"
                autoCorrect={!Browser.isMobileSafari()}
                placeholderTextColor={theme.placeholderText}
                ref={(el) => (textInput.current = el)}
                selection={selection}
                style={[inputStyleMemo]}
                value={value}
                defaultValue={defaultValue}
                autoFocus={autoFocus}
                /* eslint-disable-next-line react/jsx-props-no-spreading */
                {...props}
                onSelectionChange={addCursorPositionToSelectionChange}
                onContentSizeChange={(e) => {
                    setTextInputWidth(`${e.nativeEvent.contentSize.width}px`);
                    updateIsFullComposerAvailable({maxLines, isComposerFullSize, isDisabled, setIsFullComposerAvailable}, e, styles);
                }}
                disabled={isDisabled}
                onKeyPress={handleKeyPress}
                onFocus={(e) => {
                    ReportActionComposeFocusManager.onComposerFocus(() => {
                        if (!textInput.current) {
                            return;
                        }

                        textInput.current.focus();
                    });

                    props.onFocus?.(e);
                }}
            />

Test before changes:

Screen.Recording.2024-05-23.at.12.19.09.PM.mov

Test after changes:

Screen.Recording.2024-05-23.at.11.55.07.AM.mov

@adelekennedy
Copy link

@amyevans I also can't reproduce

@amyevans
Copy link
Contributor

@kavimuru
Copy link

kavimuru commented May 23, 2024

@amyevans Reproduced with certain devices only.

  • Issue reproducible on: Galaxy S10+ / Andriod 12, Fold 4 / Android 14(repro with samsung keyboard only and not with Gboard), Galaxy S10 / Android 11, Samsung Galaxy A50/Android11, Xiaomi Redmi Note 10S - Android 13
  • Not reproducible on Pixel devices
Screen_Recording_20240524_031719_Settings.mp4
az_recorder_20240523_151900.1.mp4
video_2024-05-23_15-14-47.mp4

Not reproducible on Pixel devices

@amyevans
Copy link
Contributor

As the @expensify/react-native-live-markdown component is out of our control (externals)

We do have some control, it's our open source repo 😄

@robertKozik would you be able to help look into this further?

@robertKozik
Copy link
Contributor

Sadly I won't be able to help for now, but I'll pass it to my colleagues which are involved in react-native-live-markdown

@amyevans
Copy link
Contributor

Thanks!

@amyevans
Copy link
Contributor

@SzymczakJ
Copy link
Contributor

Update: We need to wait for react-native-live-markdown fix to be merged. I've put out a PR with that fix Expensify/react-native-live-markdown#366. When the fix is merged I will reapply changes that Robert Kozik made, that were solving this room mentions issue, as they will no longer cause this "unable to type in compose box" bug. I think you can also assign me to that room mentions issue.

@amyevans
Copy link
Contributor

amyevans commented Jun 4, 2024

Okay thanks for the update! Can you comment on that GH, I'm unable to assign otherwise

@SzymczakJ
Copy link
Contributor

Update: we are still waiting to merge this fix in react-native-live-markdown Expensify/react-native-live-markdown#366, I'm pinging react-native-live-markdown team to merge this fix ASAP 😄

Copy link

melvin-bot bot commented Jun 6, 2024

@amyevans @mollfpr @adelekennedy @SzymczakJ this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jun 7, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jun 9, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@SzymczakJ
Copy link
Contributor

I think this can be closed, since this bug was fixed with react-native–live-markdown bump and we are now working on #41597

@amyevans
Copy link
Contributor

👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024
@melvin-bot melvin-bot bot changed the title [$250] mweb-chat-Unable to type in compose box [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box Jun 11, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @mollfpr requires payment through NewDot Manual Requests
  • @SzymczakJ does not require payment (Contractor)

Copy link

melvin-bot bot commented Jun 11, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
  • [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@mollfpr] Determine if we should create a regression test for this bug.
  • [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @mollfpr requires payment through NewDot Manual Requests
  • @SzymczakJ does not require payment (Contractor)

Copy link

melvin-bot bot commented Jun 13, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
  • [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@mollfpr] Determine if we should create a regression test for this bug.
  • [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests