-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$250] mweb-chat-Unable to type in compose box #42523
Comments
Triggered auto assignment to @amyevans ( |
Triggered auto assignment to @adelekennedy ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it. |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
We think that this bug might be related to #vip-vsb |
I'm unable to reproduce: screen-20240523-120314.mp4@adelekennedy can you give it a try? |
Removed the |
ProposalPlease re-state the problem that we are trying to solve in this issue.mweb-chat-Unable to type in compose box What is the root cause of that problem?It seems the new module "@expensify/react-native-live-markdown" is the root cause, when we pass it through our RNMarkDownTextInput component ( App/src/components/Composer/index.tsx Lines 324 to 332 in 84290e4
What changes do you think we should make in order to solve the problem?As the @expensify/react-native-live-markdown component is out of our control (externals) I suggest marking it as internal, meanwhile we can use the RNMarkDownTextInput without the new markdown styles, like:
Test before changes: Screen.Recording.2024-05-23.at.12.19.09.PM.movTest after changes: Screen.Recording.2024-05-23.at.11.55.07.AM.mov |
@amyevans I also can't reproduce |
Asked about it in #qa: https://expensify.slack.com/archives/C9YU7BX5M/p1716490376842399 |
@amyevans Reproduced with certain devices only.
Screen_Recording_20240524_031719_Settings.mp4az_recorder_20240523_151900.1.mp4video_2024-05-23_15-14-47.mp4Not reproducible on Pixel devices |
We do have some control, it's our open source repo 😄 @robertKozik would you be able to help look into this further? |
Sadly I won't be able to help for now, but I'll pass it to my colleagues which are involved in |
Thanks! |
Some discussion here: https://expensify.slack.com/archives/C06BDSWLDPB/p1716559779115879 |
Update: We need to wait for react-native-live-markdown fix to be merged. I've put out a PR with that fix Expensify/react-native-live-markdown#366. When the fix is merged I will reapply changes that Robert Kozik made, that were solving this room mentions issue, as they will no longer cause this "unable to type in compose box" bug. I think you can also assign me to that room mentions issue. |
Okay thanks for the update! Can you comment on that GH, I'm unable to assign otherwise |
Update: we are still waiting to merge this fix in react-native-live-markdown Expensify/react-native-live-markdown#366, I'm pinging |
@amyevans @mollfpr @adelekennedy @SzymczakJ this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
I think this can be closed, since this bug was fixed with |
👍 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-18. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-06-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.75-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4569546
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Expected Result:
User must be able to type in compose.
Actual Result:
User unable to type in compose. Compose is not functioning properly.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6489326_1716464220773.Screenrecorder-2024-05-23-17-03-59-903.1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @adelekennedyThe text was updated successfully, but these errors were encountered: