[HOLD for payment 2024-06-03] [$125] Web - Split scan - Excessive header space in split menu

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to https://42057.pr-testing.expensify.com/
2. Go to any chat.
3. Go to + > Split expense.
4. Split a scan expense.
5. Click on the split preview.

Expected Result:

There will be no excessive space in the split header.

Actual Result:

There is excessive space in the split header.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

330498731-982b81cc-4e9e-4ec1-b02b-f7a5da2de41e.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb522a9c968afba5
• Upwork Job ID: 1791118490892976128
• Last Price Increase: 2024-05-16

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[pecanoro]

I think it's coming from this big PR #40785. I see some of these were fixed here #41077 but not this bug.

[pecanoro]

The problem is that the whole MoneyRequestConfirmationList is now flex: 1 1 0% instead of flex: 1 1 auto as before, but not sure how to fix it.

[pecanoro]

Nvm, found a fix, creating a PR

[pecanoro]

I am going to assign Rushat for review since he was the original reviewer of the PR that caused the regression

[pecanoro]

@MrMuzyk I managed to fix this on all platforms but native here (#42231), not sure why it does not work on native platforms. We merged the fix either way to unblock the deploy, but ideally assigning this to you since we need to fix this asap for native!

[pecanoro]

That style has been there for a while though and it didn't break until we deployed #40785 🤔 But if that fixes the problem for all platforms and it doesn't break anything else, let's go ahead

[nkdengineer]

@pecanoro this PR is ready for preview

[MrMuzyk]

Sorry if I was a bit slow to react, didn't get notification for some reason 😓 Looks like @nkdengineer PR fixes the issue on native. Web works fine too

[RickDeb2004]

@MrMuzyk @rushatgabhane should I try this issue, but it seems that issue is resolved

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~017738fb94de003574

[melvin-bot]

📣 @RickDeb2004! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rushatgabhane]

PR approved

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.75-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix styles for split preview #42231
• fix: Split scan - Excessive header space in split menu #42329

If no regressions arise, payment will be issued on 2024-06-03. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: fix Top and bottom borders of header status #41643

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix Top and bottom borders of header status #41643 (review)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No because it was caught by QA and will come up easily when split flow is tested

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

@isabelastisser could you please attach payment summary for this issue thank you 🙇

[isabelastisser]

Payment summary:

@rushatgabhane requires payment through NewDot Manual Requests. $125 C+ review PENDING
@nkdengineer requires payment. $125 Contributor. I sent you the offer in Upwork now: https://www.upwork.com/ab/applicants/1791118490892976128/job-details

[nkdengineer]

@isabelastisser I accepted the offer, thanks 🙇

[JmillsExpensify]

$125 approved for @rushatgabhane

[isabelastisser]

All set!