-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LHN - Conversation is not scrolled in LHN after chat switching #4216
Comments
Triggered auto assignment to @sketchydroide ( |
@sketchydroide Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@sketchydroide Eep! 4 days overdue now. Issues have feelings too... |
This did not appear on K2, I did not know of it, will take a look today |
@isagoico do you know if this ever happened? I'm not sure it has... |
I don't think it happened before 🤔 But I agree it would be a nice thing to have. |
I'm a lil confused too, but I think I get it... So.. we need to decide...
I think we can toss #2 because, since the chat is already in the main pane once you've selected the user in search, there's no actionable reason why you'd need/want to click that same user in LHN. The reason to potentially change our current setup would be to keep that chat in LHN even if you didn't send a message. I can't think of a specific use case where that would be beneficial, my first 'vote' is #3 and do nothing |
Yeah I think I'm with you here Matt, After a couple of days thinking, I don't see any benefit for the user to have this, there is no action they can/need to do in the user they are chatting with. I would very much prefer to have something happen to all the chats that have unread messages, sometimes I need to look around for whatever chat/user/room has unread messages. But I think a filter button, or read all unread messages button would do the trick for that. Either way that is not related to this GH. |
@sketchydroide check out #focus mode in Preferences, it'll show all unread in LHN. @quinthar since you brought up the issue, do you have more thoughts/feedback? I want to make sure we're not 'missing something' |
Bumping this, not sure if anyone will have time "allocation" to answer this week, so I'm keeping this open for another week or 2 |
Ok I'm closing this, it does seem to be a priority, or needed, if we change our minds we can open it again. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Conversation should be in the visible area of the LHN after chat switching.
Actual Result:
Conversation is not scrolled and in view in LHN after chat switching
Workaround:
User has to scroll to the bottom of the list to find the current chat.
Platform:
Where is this issue occurring?
Version Number: 1.0.80-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.200.mp4
Expensify/Expensify Issue URL:
View all open jobs on Upwork
From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1626918594122600
The text was updated successfully, but these errors were encountered: