Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - Conversation is not scrolled in LHN after chat switching #4216

Closed
2 of 5 tasks
isagoico opened this issue Jul 24, 2021 · 11 comments
Closed
2 of 5 tasks

LHN - Conversation is not scrolled in LHN after chat switching #4216

isagoico opened this issue Jul 24, 2021 · 11 comments
Assignees

Comments

@isagoico
Copy link

isagoico commented Jul 24, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Log in to New Expensify
  2. Be sure to use an account that has several chats opened
  3. Click on the search icon
  4. Search for a user that you don't have a conversation with

Expected Result:

Conversation should be in the visible area of the LHN after chat switching.

Actual Result:

Conversation is not scrolled and in view in LHN after chat switching

Workaround:

User has to scroll to the bottom of the list to find the current chat.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.0.80-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.200.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1626918594122600

Switching to a chat on desktop Chrome doesn't cause it to appear in the LHN.

@MelvinBot
Copy link

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot
Copy link

@sketchydroide Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MelvinBot
Copy link

@sketchydroide Eep! 4 days overdue now. Issues have feelings too...

@sketchydroide
Copy link
Contributor

This did not appear on K2, I did not know of it, will take a look today

@MelvinBot MelvinBot removed the Overdue label Aug 2, 2021
@sketchydroide
Copy link
Contributor

sketchydroide commented Aug 2, 2021

@isagoico do you know if this ever happened? I'm not sure it has...
This does sound like a nice thing to have, but needs some verification if this is a improvement or a bug.

@sketchydroide sketchydroide added Weekly KSv2 and removed Daily KSv2 labels Aug 2, 2021
@isagoico
Copy link
Author

isagoico commented Aug 2, 2021

I don't think it happened before 🤔 But I agree it would be a nice thing to have.

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Aug 4, 2021

I'm a lil confused too, but I think I get it...
When in "Most recent" mode, if you search then select a chat with a user, but don't send them a message, the chat doesn't show up in LHN, right? (also.. if you type a draft it doesn't show in LHN either).

So.. we need to decide...

  1. Should the chat show even if no new message was sent?
  2. Should it show temporarily while you have the chat open in the main pane, then disappear if no chat has been sent
  3. Current - continues to not show in LHN until a message has been sent or received.

I think we can toss #2 because, since the chat is already in the main pane once you've selected the user in search, there's no actionable reason why you'd need/want to click that same user in LHN. The reason to potentially change our current setup would be to keep that chat in LHN even if you didn't send a message. I can't think of a specific use case where that would be beneficial, my first 'vote' is #3 and do nothing

@sketchydroide
Copy link
Contributor

Yeah I think I'm with you here Matt, After a couple of days thinking, I don't see any benefit for the user to have this, there is no action they can/need to do in the user they are chatting with.

I would very much prefer to have something happen to all the chats that have unread messages, sometimes I need to look around for whatever chat/user/room has unread messages. But I think a filter button, or read all unread messages button would do the trick for that. Either way that is not related to this GH.

@mallenexpensify
Copy link
Contributor

@sketchydroide check out #focus mode in Preferences, it'll show all unread in LHN.

@quinthar since you brought up the issue, do you have more thoughts/feedback? I want to make sure we're not 'missing something'

@sketchydroide
Copy link
Contributor

Bumping this, not sure if anyone will have time "allocation" to answer this week, so I'm keeping this open for another week or 2

@sketchydroide
Copy link
Contributor

Ok I'm closing this, it does seem to be a priority, or needed, if we change our minds we can open it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants