[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Details Revamp] Remove DetailsPage.tsx

[grgia]

https://docs.google.com/document/d/1-xSZdSZZIuIl0fPO7yypkKfcbWEsnNFAs50ptgL3Gnw/edit#bookmark=id.azg8eofhvuhz

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[kosmydel]

Hey, I'm from SWM and I will work on this.

[trjExpensify]

@kosmydel will this one effectively come last with the changes, or are we waiting on something else?

[kosmydel]

@kosmydel will this one effectively come last with the changes, or are we waiting on something else?

We are currently waiting for the PRs at #42188 and #41972 to be merged. I don't want to open this PR yet because there might be changes during the review process of the above PRs that could impact the review process of this one (as this PR is based on the above ones).

[trjExpensify]

Nice, so #42188 to go!

[kosmydel]

This one is waiting for #42188, but I opened it for review anyway to speed up the process a bit (I've notified the C+ that it is not based on the main branch).

[kosmydel]

We can take this issue off hold as the blocking PR was merged :)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@kosmydel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• cleanup: remove DetailsPage.tsx  #42385

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @kosmydel does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@kosmydel] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[anmurali]

@kosmydel - can you propose regression test steps?

[kosmydel]

Hey @anmurali, I've never done something like this, but here you are:

1. Go to a report.
2. Mention a user that doesn't exist in the Onyx (e.g. @+3213972183, @[email protected])
3. Click the mention to open the Profile page. Verify that everything is displayed correctly and works.
4. Repeat the above steps for multiple accounts (phone numbers, emails, etc.).
5. Verify the above for invalid account IDs (e.g. https://staging.new.expensify.com/a/hellodsdsdsdsdsd)
6. Verify the above for random account IDs (e.g. https://staging.new.expensify.com/a/3213112)
7. Click the user profile picture to open the Profile page. Verify that everything is displayed correctly and works.

[melvin-bot]

@shawnborton, @anmurali, @grgia, @kosmydel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[anmurali]

@grgia - do you agree with those regression steps. I would love a review since @kosmydel has not written one of these before.

[grgia]

@anmurali @kosmydel

Great work on these @kosmydel ! I made some minor tweaks, could you confirm my changes?

1. Go to a chat report.
2. Mention a user that you've never interacted with and doesn't exist in Onyx (e.g. @+3213972183, @[email protected])
3. Click on the mention to open the Profile page.
   ✅ Verify that everything is displayed correctly and works.
4. Repeat the above steps for multiple accounts (phone numbers, emails, etc.).
   ✅ Verify that "page not found" is shown for invalid account IDs (e.g. https://staging.new.expensify.com/a/hellodsdsdsdsdsd)
   ✅ Verify that personal details page loads for random account IDs (e.g. https://staging.new.expensify.com/a/3213112)
5. Click the user profile picture to open the Profile page.
   ✅ Verify that everything is displayed correctly and works.

[kosmydel]

Looks great @grgia!

[shawnborton]

Not overdue! Working out final details but we have this live in product.

[grgia]

@anmurali I think we've got everything we need to close this one out

[melvin-bot]

@shawnborton, @anmurali, @grgia, @kosmydel Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@shawnborton, @anmurali, @grgia, @kosmydel 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@shawnborton, @anmurali, @grgia, @kosmydel 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[shawnborton]

@anmurali friendly bump

[anmurali]

No payments needed. Regression test added.