Chat - Mention whisper returns, incorrect mention buttons

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.71.0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #41406
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Log in with a nexpensifail user
2. Create a room
3. Write any message
4. Thread the message and write any text
5. Tag a non-existing user in the thread
6. Copy the code from the PR
7. Paste it into Chrome console and replace "id" in the last row with the thread ID from the URL
8. Click on "Yes"

Expected Result:

The buttons should be "Create it" and "Do nothing".
The whisper message shouldn't return.

Actual Result:

The whisper buttons turned to "Yes" and "No".
The whisper message returns after 10-80 seconds.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6474245_1715113847792.bandicam_2024-05-07_22-20-56-574.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@dylanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

Production

Recording.2428.mp4

[dylanexpensify]

@izarutskaya is this only occurring with Expensifail accounts?

[dylanexpensify]

Confirmed reproduction, though not sure if this is a deploy blocker if only impacting expensifail accounts. cc @pecanoro

[pecanoro]

Copy the code from the PR

Which PR? Is this coming from QAing something in particular?

@dylanexpensify How did you reproduce it?

[rlinoz]

We changed this so the buttons should be Yes and No, but also I think we can mark this PR as NO QA and close this issue, there is still a pending Auth PR https://github.com/Expensify/Auth/pull/10734 to make everything work and the end user won't be able to see the report mention whisper until we merge the Auth PR.