[HOLD for payment 2024-05-09] Mark Down - Mark down doesn't work for task description after saving

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Click on FAB > Assign task
3. Input a title
4. Input a description with a mark down text (e.g "> test")
5. Create the task by assigning to someone and sharing it somwhere
6. Open the task report page

Expected Result:

The description renders the markdown

Actual Result:

The description field doesn't render the appropriate markdown text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6467994_1714573165721.bandicam_2024-05-01_17-15-16-315.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@srikarparsi FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mark Down - Mark down doesn't work for task description after saving

What is the root cause of that problem?

It's because we are escaping it. We should only escape urls. but due to false we are escaping normal description too.

App/src/components/ReportActionItem/TaskView.tsx

Line 154 in 33a496e

shouldEscapeText={Url.hasURL(report.description ?? '') ? undefined : false}

What changes do you think we should make in order to solve the problem?

Instead of false we should change it to true

 shouldEscapeText={Url.hasURL(report.description ?? '') ? undefined : true}

App/src/components/ReportActionItem/TaskView.tsx

Line 154 in 33a496e

shouldEscapeText={Url.hasURL(report.description ?? '') ? undefined : false}

Also remove

App/src/components/ReportActionItem/TaskView.tsx

Line 153 in c4a1c59

shouldRenderAsHTML

Solution 2
We should remove these two lines.

App/src/components/ReportActionItem/TaskView.tsx

Lines 153 to 154 in 8661f6a

	shouldRenderAsHTML
	shouldEscapeText={Url.hasURL(report.description ?? '') ? undefined : false}

What alternative solutions did you explore? (Optional)

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mark down doesn't work for task description after saving.

What is the root cause of that problem?

shouldEscapeText is being passed as false to MenuItemWithTopDescription via TaskView when there's no URL.

shouldEscapeText={Url.hasURL(report.description ?? '') ? undefined : false}

What changes do you think we should make in order to solve the problem?

We don't need to pass shouldEscapeText, we can simply remove the below line:

shouldEscapeText={Url.hasURL(report.description ?? '') ? undefined : false}

[francoisl]

Thanks for the proposals. Please make sure to link to the offending PR that caused the regression when you can identify it, in this case it looks like it was #41096.

Going to test the proposals shortly.

[francoisl]

Thanks guys, I'm going to handle this internally because it requires changing some additional values for the onboarding tasks.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix markdown rendering for task descriptions, fix onboarding task descriptions #41436

If no regressions arise, payment will be issued on 2024-05-09. 🎊

[francoisl]

This was all handled internally, closing.