[$250] [Violations] Expense - RBR appears in report preview but no violation message in transaction thread

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Submit expense.
3. Submit an expense to any user.
4. Submit another expense to the same user again.
5. Click on the expense preview in the main chat.
6. Click on the preview that has red dot.

Expected Result:

There should be violation message in transaction thread for expense that has a red dot.

Actual Result:

Red dot appears in expense preview in the report, but there is no violation message in the transaction thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6467470_1714543806924.red_red_red.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2a023aff3cd4279
• Upwork Job ID: 1785642421475364864
• Last Price Increase: 2024-05-01

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[MariaHCD]

Able to reproduce on dev:

Screen.Recording.2024-05-01.at.4.01.05.PM.mov

There doesn't seem to be an error with the creation of the money requests themselves and I don't see any recent changes to the shouldShowRBR logic in ReportPreview component that might've caused this. Adding External to get more eyes on this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2a023aff3cd4279

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MariaHCD]

Seems like there's a cashExpenseWithNoReceipt violation on those transactions.

I'm not super sure if these transactions should be flagged with this violation...

[MariaHCD]

Need to get some more eyes on this, raising in #wave-control: https://expensify.slack.com/archives/C06ML6X0W9L/p1714572168631129

And expensify-open-source: https://expensify.slack.com/archives/C01GTK53T8Q/p1714571039687799?thread_ts=1714565359.644339&cid=C01GTK53T8Q

[francoisl]

Discussed internally (link 1, link 2), this can be fixed from the backend and violations are still under a beta, so we're not going to block the NewDot deploy on this.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

[JmillsExpensify]

Pulling from our convo in Slack, I think we should move to remove most violations from IOUs, including notes like cashExpenseWithNoReceipt. That said, we still need to support the case of receipt scanning failures, so NAME_RECEIPT_NOT_SMART_SCANNED.

The other case I can think of is Hold, which is supported on IOU report, though isn't Hold an expenseNVP?

[robertjchen]

With regards to Hold- it is a reportAction, but we do have some violation logic in place at the transaction level. We could make an exception there to avoid flagging held requests as a violation if it happens to be on an IOU report.

[cead22]

If I'm understanding Jason correctly, we want to return HOLD violations on IOUs. Is that right?

[JmillsExpensify]

Yes, that's correct. Hold is a feature of all report types.

[melvin-bot]

@cead22, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[cead22]

I submitted a PR to stop returning cashExpenseWithNoReceipt for new dot, which should fix this

[melvin-bot]

@cead22, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@cead22, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

@cead22 Can we close this issue out now?

[cead22]

Yup