[QBO] Features in More features remain locked after disconnecting the QBO integration

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.68-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714512653698929?thread_ts=1714400674.229349&cid=C036QM0SLJK

Action Performed:

1. Connect a workspace to QBO
2. Go to More Features
3. Observe the locked toggles on the Categories, Tags and Taxes menu items
4. Go back to Accounting > three dot menu > Disconnect QBO > confirm
5. Go back to More features
6. Observe the locked toggles remain on the menu items
7. Toggle off Accounting
8. Observe the locked toggles are removed from the menu items

Expected Result:

When you disconnect a workspace from QBO, the coding menu items for Categories, Tags and Taxes should not be locked anymore.

Actual Result:

They remain locked until you disable Accounting.

Workaround:

Yes, disable Accounting.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-04-30_23-14-23.mp4

View all open jobs on GitHub

CC: @hayata-suenaga @aldo-expensify @zanyrenney @s77rt @narefyev91 @teneeto

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[hayata-suenaga]

We're relying on the hasAccountingConnection variable to decided if these toggle buttons should be locked or not.

The value of the variable is set here.

const hasAccountingConnection = !!policy?.areConnectionsEnabled && !!policy?.connections;

It's either areConnectionsEnabled or connections fields are outdated or both are outdated when the connection is removed. The pusher updates might not be sent correctly when the connection is removed.

We probably update areConnectionsEnabled or connections field around here

@aldo-expensify, since you worked on this PR, is it possible to investigate this further from here? 🙇

[s77rt]

This has been fixed in #40984. We can close this

[trjExpensify]

Got it, maybe let's verify that once it hit staging.

[melvin-bot]

@trjExpensify, @s77rt Eep! 4 days overdue now. Issues have feelings too...

[trjExpensify]

Linked PR has been deployed, did you retest this @s77rt?

[hayata-suenaga]

removed the hold

[s77rt]

Just retested, the issue is fixed 🎉

Screen.Recording.2024-05-07.at.4.38.24.PM.mov

[trjExpensify]

Niceeeeee! Closing!