-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAY] 2 copies of react-pdf are included in the web js bundle #41237
Comments
Triggered auto assignment to @mallenexpensify ( |
Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Assigned to @ahmedGaber93 as they're reviewing the PR. |
Reviewed and merged the PR after being tagged in slack |
This issue has not been updated in over 15 days. @mallenexpensify, @ahmedGaber93, @roryabraham eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
This has been merged already, can we close it? |
Thanks for the ping @janicduplessis . @ahmedGaber93 , you're due $250 here, right? Assuming so, can you please accept the job and reply here once you have? |
Yes, right. Offer accepted thanks @mallenexpensify |
Contributor+: @ahmedGaber93 paid $250 via Upwork. Thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Latest
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @janicduplessis
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1714407724836209?thread_ts=1714247539.428689&cid=C05LX9D6E07
Action Performed:
Expected Result:
There should only be 1 copy of react-pdf
Actual Result:
There are 2 copies of react-pdf
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: