Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIGH: [UX Reliability] Fix native Android keyboard selection #40994

Closed
quinthar opened this issue Apr 25, 2024 · 5 comments
Closed

HIGH: [UX Reliability] Fix native Android keyboard selection #40994

quinthar opened this issue Apr 25, 2024 · 5 comments
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@quinthar
Copy link
Contributor

quinthar commented Apr 25, 2024

Being discussed here: https://expensify.slack.com/archives/C05LX9D6E07/p1714055772402719?thread_ts=1713918954.937979&cid=C05LX9D6E07

@quinthar quinthar converted this from a draft issue Apr 25, 2024
@quinthar
Copy link
Contributor Author

@hurali97 Can you please flesh this issue out with a problem/solution statement? Thanks!

@hurali97
Copy link
Contributor

hurali97 commented Apr 26, 2024

Problem:

The user is unable to select text in the composer. See the below video:

video
screen-20240423-173445.mp4

Solution:

The issue is originating from the usage of MarkDownTextInput in the composer. If we replace MarkDownTextInput with TextInput from react-native the issue is fixed. See the below video:

video
vid.mp4

The solution here is not to replace MarkDownTextInput but rather fix the root cause inside of this library. Folks from SWM worked on this library and they are the best fit to take this from here but in case they don't have the bandwidth, we can help narrowing down this issue and fixing it at the root.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Apr 26, 2024
Copy link

melvin-bot bot commented Apr 27, 2024

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@quinthar quinthar changed the title HIGH: [Reliability] Fix native Android keyboard selection HIGH: [UX Reliability] Fix native Android keyboard selection Apr 27, 2024
@quinthar
Copy link
Contributor Author

Will be fixed by #40890, closing this one.

@hayata-suenaga
Copy link
Contributor

I'll close this issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants