Distance - Mileage Rate changes from previous value when editing waypoints

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.64-0
Reproducible in staging?: Y
Reproducible in production?: No, new feature
Found when validating PR : #38543
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: User should be an employee of a collect workspace which has a custom mileage rate

1. Navigate to staging.new.expensify.com
2. Click on FAB > Submit expense > Distance
3. Insert start and finish points
4. Select the collect workspace
5. Select the custom rate and create the request
6. Open the expense report of the created distance request
7. Click on distance
8. Invert the order of the waypoints

Expected Result:

Rate should not change but retain its selected custom rate

Actual Result:

Mileage rate changes to default rate after editing waypoints

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6458462_1713857607407.bandicam_2024-04-23_10-22-21-555.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01572c3a6ba1c412f4
• Upwork Job ID: 1782796238303707136
• Last Price Increase: 2024-04-23

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@kadiealexander I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[koko57]

Looks like something from the New Rate Field PR

cc @mountiny

[mountiny]

Assigning, its a new feature, I dont think we have to block deploy on this

[koko57]

@neil-marcellini shouldn't it be fixed on the backend? I'm not sending the rate ID for UpdateMoneyRequestDistance, yet I get the default rate ID instead of the previous one in the response

[mountiny]

@neil-marcellini would you be able to take this over given you have context?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01572c3a6ba1c412f4

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @akinwale (Internal)

[neil-marcellini]

I'll start working on a backend fix now.

[melvin-bot]

@akinwale, @neil-marcellini, @koko57, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@akinwale, @neil-marcellini, @koko57, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@akinwale, @neil-marcellini, @koko57, @kadiealexander Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@akinwale, @neil-marcellini, @koko57, @kadiealexander Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@akinwale, @neil-marcellini, @koko57, @kadiealexander 10 days overdue. Is anyone even seeing these? Hello?

[arielgreen]

@kadiealexander removing this from the split project as it's re workspaces (split is only off-workspace)

[melvin-bot]

This issue has not been updated in over 14 days. @akinwale, @neil-marcellini, @koko57, @kadiealexander eroding to Weekly issue.

[neil-marcellini]

Wow this issue got kind of buried. Let's see what the status is.

[neil-marcellini]

This was fixed a long time ago with this PR, and was marked as passing QA 2 weeks ago in this comment