Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #40412] Live MD - No top margin for only emojis inside the expanded compose box #40472

Closed
2 of 6 tasks
lanitochka17 opened this issue Apr 18, 2024 · 13 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Open any chat
  3. Add an emoji only
  4. Enter a new line
  5. Expand the compose box

Expected Result:

There is a margin between the emoji inside the compose box and the top border of the compose box

Actual Result:

There is space between the emoji inside the compose box and the top border of the compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453394_1713431122292.bandicam_2024-04-18_12-00-18-497.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@MahmudjonToraqulov
Copy link
Contributor

This will be fixed with this Proposal

@MahmudjonToraqulov
Copy link
Contributor

Result

photo_2024-04-18_20-56-01

@roryabraham
Copy link
Contributor

calling this NAB and putting it on HOLD for #40412 as it appears to share the same root cause.

@roryabraham roryabraham added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 18, 2024
@roryabraham roryabraham changed the title Live MD - No top margin for only emojis inside the expanded compose box [HOLD #40412] Live MD - No top margin for only emojis inside the expanded compose box Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
Copy link

melvin-bot bot commented Apr 22, 2024

@roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

@roryabraham
Copy link
Contributor

Still on HOLD - making this a weekly while we wait for #40412 to land

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Apr 22, 2024
@melvin-bot melvin-bot bot added the Overdue label May 1, 2024
@roryabraham
Copy link
Contributor

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2024
@melvin-bot melvin-bot bot added the Overdue label May 10, 2024
@roryabraham
Copy link
Contributor

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label May 11, 2024
@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@roryabraham
Copy link
Contributor

still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

This issue has not been updated in over 15 days. @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@roryabraham
Copy link
Contributor

Verified that this is fixed

image

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants