Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] iOS - Chat - Emojis are not displayed properly in the emoji picker #40360

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 17, 2024 · 15 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.62-14
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to any chat
  3. Open emoji picker

Expected Result:

The emojis are displayed properly in the emoji picker

Actual Result:

The emojis are not displayed properly in the emoji picker

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6452508_1713368952576.RPReplay_Final1713368836.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f12625c61a6be308
  • Upwork Job ID: 1780702679365181440
  • Last Price Increase: 2024-04-17
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsb

@rlinoz
Copy link
Contributor

rlinoz commented Apr 17, 2024

Not being able to repro, gonna ask for help on slack

@dylanexpensify
Copy link
Contributor

Can repro @rlinoz!

@rlinoz
Copy link
Contributor

rlinoz commented Apr 17, 2024

Hmmm maybe this is related to FlashList as well.

@rlinoz
Copy link
Contributor

rlinoz commented Apr 17, 2024

Ok, after cleaning node modules and starting over it is reproducible in the emulator.

@rlinoz
Copy link
Contributor

rlinoz commented Apr 17, 2024

I'm not sure how to solve this and I gotta go, so I will open up for proposals.

@rlinoz rlinoz added External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01f12625c61a6be308

@melvin-bot melvin-bot bot changed the title iOS - Chat - Emojis are not displayed properly in the emoji picker [$250] iOS - Chat - Emojis are not displayed properly in the emoji picker Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@strepanier03
Copy link
Contributor

This was repro'd by an Expensify employee with a physical device. I don't have an iPhone and my browserstack isn't working right now, the app crashes.


I don't necessarily think this should block deploy though. The emoji picker still works, you can search for an emoji to narrow down results, and it's working elsewhere.

I'm in no way an expert on deploying so I'll wait for more knowledgeable individuals to weigh in.

@roryabraham
Copy link
Contributor

I do think this should be a deploy blocker, the emoji picker looks very broken

@rlinoz
Copy link
Contributor

rlinoz commented Apr 18, 2024

This is fixed, thanks!

image

@rlinoz rlinoz removed the DeployBlockerCash This issue or pull request should block deployment label Apr 18, 2024
@rlinoz rlinoz closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants