Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quick Button track expenses names #40324

Closed
Gonals opened this issue Apr 17, 2024 · 5 comments
Closed

Fix Quick Button track expenses names #40324

Gonals opened this issue Apr 17, 2024 · 5 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@Gonals
Copy link
Contributor

Gonals commented Apr 17, 2024

Problem
In Track flows, the quick button states "Track manual" and "Track scan" when it should say "Track expense" and "Track receipt"

Solution
Fix it

@Gonals Gonals added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 17, 2024
@Gonals Gonals self-assigned this Apr 17, 2024
Copy link

melvin-bot bot commented Apr 17, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Gonals Gonals mentioned this issue Apr 17, 2024
50 tasks
@Gonals
Copy link
Contributor Author

Gonals commented Apr 17, 2024

No need for c+ on this one, since it is just a very small copy change

@zanyrenney
Copy link
Contributor

@Gonals, please can you ensure you update this issue with the ksv2 cadence? It's half me to know what's going on here and what my action is. It sounds like this contributor is working on this and you will potentially review the change? Is that the plan?

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@Gonals
Copy link
Contributor Author

Gonals commented Apr 22, 2024

Nope. I worked on it myself and it is already merged (with no contributors involved), so nothing more to do here. You can probably unassign yourself 😁

@Gonals Gonals added Improvement Item broken or needs improvement. Engineering Reviewing Has a PR in review labels Apr 22, 2024
@Gonals
Copy link
Contributor Author

Gonals commented Apr 23, 2024

Deployed to prod

@Gonals Gonals closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants