[HOLD for payment 2024-06-05] Fix notification preferences for Group Chats so they are "immediate" instead of "hidden"

[marcaaron]

Coming from https://expensify.slack.com/archives/C05RECHFBEW/p1712957522045629

Problem

When we implemented Group Chats we followed the existing pattern for our Group DMs where all users start with a notificationPreference of 'hidden' on the chat. This optimization existed so that any empty chats would not show up for users without any content in their LHN.

However, upon reflection we have decided that this should behave closer to the existing "Rooms" behavior. Additionally, since we are adding descriptions to Group Chats this will help contextualize the experience for any invited users (see: #40312).

Solution

This will be an entirely backend change for the most part. We need to change the logic here when creating a Group Chat.

And numerous tests.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0163fccf2efd233395
• Upwork Job ID: 1780335646090248192
• Last Price Increase: 2024-04-16

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0163fccf2efd233395

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[marcaaron]

Since this is a backend issue I'm gonna remove @Santhosh-Sellavel

[srikarparsi]

Will do this this week.

[JmillsExpensify]

Any progress on this one?

[srikarparsi]

Sorry, haven't been able to work on this but will get at least a draft PR and hopefully a full PR out tomorrow.

[saracouto]

@srikarparsi are you working on this? The status is unassigned right now so I want to make sure it is categorized correctly!

[srikarparsi]

Hey! Yeah I am, have both PRs up, the Auth one still needs a little work to get the tests to pass. I think ETA is Thursday or Friday.

[srikarparsi]

Tests are failing. (I accidentally commented about a different PR in this PR 2 weeks ago)

[srikarparsi]

No update this week. Will try to get to this during onshore.

[srikarparsi]

No update yet

[srikarparsi]

No update yet. I should be able to get to this next week

[srikarparsi]

Focussed on other priorities

[srikarparsi]

No update

[srikarparsi]

No update, moving this to monthly because I don't think it's too high of a priority but I started it so going to try to finish

[srikarparsi]

https://github.com/Expensify/Auth/pull/12532#issuecomment-2409826688

[srikarparsi]

^