-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Add back the parallax animation in the new arch #40309
Comments
cc @WoLewicki |
Commenting |
@WoLewicki any update here? I wonder if that the performance problem with the parallax animation and live markdown might actually be indicative of a broader performance regression with the new arch |
Yeah, the PR is there: #41103. Sorry, I forgot to link it here. As for the regression, there still might be points where there are regressions in performance connected to the new arch and we are trying to find them and resolve each time we see any. Also, for some reason I cannot open the slack link 😕 |
This was done in two places: |
Hey @roryabraham , since I reviewed #41103, can you reopen this to handle the payment? |
Job added to Upwork: https://www.upwork.com/jobs/~0103e0b53e212479af |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
Triggered auto assignment to @lschurr ( |
📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@lschurr this is ready to pay right away, and the only payment that's due is $250 to @hungvu193 for the review |
Great, all set! Payment sent to @hungvu193 in Upwork. |
Problem
The gyroscope parallax animation was causing serious performance issues on the new arch, so we reverted it in #40302
Solution
Address the root cause of the problem and add the animation back.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hoangzinhThe text was updated successfully, but these errors were encountered: