Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Add back the parallax animation in the new arch #40309

Closed
roryabraham opened this issue Apr 16, 2024 · 12 comments
Closed

[$250] Add back the parallax animation in the new arch #40309

roryabraham opened this issue Apr 16, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 16, 2024

Problem

The gyroscope parallax animation was causing serious performance issues on the new arch, so we reverted it in #40302

Solution

Address the root cause of the problem and add the animation back.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0103e0b53e212479af
  • Upwork Job ID: 1795458292540534784
  • Last Price Increase: 2024-05-28
  • Automatic offers:
    • hungvu193 | Contributor | 102495616
Issue OwnerCurrent Issue Owner: @hoangzinh
@roryabraham
Copy link
Contributor Author

cc @WoLewicki

@WoLewicki
Copy link
Contributor

Commenting

@roryabraham
Copy link
Contributor Author

@WoLewicki any update here? I wonder if that the performance problem with the parallax animation and live markdown might actually be indicative of a broader performance regression with the new arch

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
@WoLewicki
Copy link
Contributor

WoLewicki commented May 6, 2024

Yeah, the PR is there: #41103. Sorry, I forgot to link it here. As for the regression, there still might be points where there are regressions in performance connected to the new arch and we are trying to find them and resolve each time we see any. Also, for some reason I cannot open the slack link 😕

@melvin-bot melvin-bot bot removed the Overdue label May 6, 2024
@roryabraham
Copy link
Contributor Author

@hungvu193
Copy link
Contributor

hungvu193 commented May 20, 2024

Hey @roryabraham , since I reviewed #41103, can you reopen this to handle the payment?

@roryabraham roryabraham reopened this May 28, 2024
@roryabraham roryabraham added Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels May 28, 2024
@roryabraham roryabraham moved this from Todo to Done in RN: New Architecture May 28, 2024
@melvin-bot melvin-bot bot changed the title Add back the parallax animation in the new arch [$250] Add back the parallax animation in the new arch May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0103e0b53e212479af

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

Copy link

melvin-bot bot commented May 28, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 28, 2024
@roryabraham roryabraham assigned hungvu193 and unassigned hoangzinh May 28, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 28, 2024
@roryabraham roryabraham self-assigned this May 28, 2024
Copy link

melvin-bot bot commented May 28, 2024

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@roryabraham roryabraham added the Awaiting Payment Auto-added when associated PR is deployed to production label May 28, 2024
@roryabraham
Copy link
Contributor Author

@lschurr this is ready to pay right away, and the only payment that's due is $250 to @hungvu193 for the review

@lschurr
Copy link
Contributor

lschurr commented May 28, 2024

Great, all set! Payment sent to @hungvu193 in Upwork.

@lschurr lschurr closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task
Projects
No open projects
Development

No branches or pull requests

6 participants