[$250] [HOLD for payment 2024-06-11] [Wave Collect] [Xero] [Imported Features and Taxes] Make Categories, Tags, and Taxes read-only when the user is connected to Xero

[lakchote]

As noted here for QBO, we need to prevent the user from taking actions when the user is connected to Xero.

When the user connects to Xero:

• optimistically clear all existing categories, tags and taxes the user might have had on the policy, when they add the Xero connection
• prevent the user from turning off categories, tags and taxes features
• prevent the user from deleting categories, tags and taxes imported from Xero
• prevent the user from adding new categories, tags and taxes

This will be worked on by SWM engineers, see Slack discussion here.

Until the Xero authorization flow (NewDot issue) is done (which entails NewDot, Web-E and IS changes), we won't be able to work on this yet.

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bf513d396cfd4d35
• Upwork Job ID: 1800169199603790711
• Last Price Increase: 2024-06-10

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the NewFeature assigner, not assigning anyone new.

[joekaufmanexpensify]

@lakchote should I be finding someone from SWM to do this, or just waiting for someone who already committed to do it to pick it up?

[lakchote]

@lakchote should I be finding someone from SWM to do this, or just waiting for someone who already committed to do it to pick it up?

I've asked here, if SWM engineers can pick this up!

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[joekaufmanexpensify]

Great. TY! @SzymczakJ is there an eta for a PR here?

[SzymczakJ]

@joekaufmanexpensify there should be the same task for QBO integration that would solve this issue(they also connect to accounting software and should make categories etc. read-only), but I cannot find it, so I'm not sure if it's already worked on by them. Also if nobody is taking care of it I do it 😃 cc @mountiny

[joekaufmanexpensify]

@SzymczakJ, are you referring to this issue? If so, do you mean that the QBO issue will solve this for Xero too, and we can consolidate both into that issue?

[SzymczakJ]

Sorry for late response, I was OOO. The issue you mentioned isn't solving this issue completely, it only disables switches for taxes/categories but the user is still able to edit categories etc.(as shown on video).

swtichblocked.mov

Previously I thought that making categories/taxes read-only was also the case for QBO and that's why I said it will be solved with QBO but maybe that isn't the case. Anyways the issue you mention isn't solving our issue completely and I don't see any open QBO issue that would solve this, so I could take care of that. cc @lakchote

Also is it only a Xero thing that the categories should be read-only and in case of QBO the user should be able to edit it freely?

[lakchote]

Previously I thought that making categories/taxes read-only was also the case for QBO and that's why I said it will be solved with QBO but maybe that isn't the case. Anyways the issue you mention isn't solving our issue completely and I don't see any open QBO issue that would solve this, so I could take care of that. cc @lakchote

Also is it only a Xero thing that the categories should be read-only and in case of QBO the user should be able to edit it freely?

It shouldn't be a Xero thing only; from my understanding when you have an accounting integration connected it is the source of truth and the categories should come from this source only. So, it should be read only for both QBO and Xero from my understanding.

Could we have your opinions @trjExpensify @zanyrenney please?

[SzymczakJ]

Another question for design/product: How read-only state should be displayed? I have some idea but I want to make sure.
This is how edit category flow looks like

readwriteflow.mov

We have few options of editing:
a) enable/disable category with a toggle click
b) change the name of category with clicking on category name
c) delete category by clicking three dots
d) select multiple categories and disable/delete them

My idea would look like this:
We are disabling enable/disable toggle( a) option), making category name MenuItem non-interactive, so only the name is displayed ( b) option), deleting three dots on CategorySettingsPage ( c) option) and finally disabling select multiple options on category list on WorkspaceCategoriesPage ( d) option).

Screen.Recording.2024-05-06.at.15.45.39.mov

WDYT @zanyrenney @trjExpensify

[SzymczakJ]

another question: the user has ability to enable/disable import of taxes,categories, etc.. We should only make taxes(and similarly categories, etc.) read-only when the import taxes toggle is on, right?

[trjExpensify]

Hey - catching up here after being OoO yesterday. To be sure I'm following the question, we're trying to decide what you shouldn't be able to do with imported coding values (i.e categories, tags, tax rates etc) when connected to an accounting solution. Is that right?

If so, then the answer is you shouldn't be able to Add new values manually, and you shouldn't be able to Delete imported values. This was missed with the initial QBO implementation PRs, but I created an issue for it and a PR linked to it has merged awaiting a deploy: #41274

[SzymczakJ]

I've looked into this and found couple things that didn't get solved.

1. You can still add/delete tags when being connected to accounting integration

2. You can still add/ delete taxes when being connected to accounting integration I could fix that issues in this task.

Also I have one important question. Should taxes, etc. be read-only when we are connected to accounting integration(with or without clicking import) or when we are connected to accounting integration AND clicking on import taxes, etc. I ask because sometimes we base on syncTax property and sometimes we base on isThereAnyAccountingConnection property and I got confused 😃
@trjExpensify @lakchote

[trjExpensify]

1. You can still add/delete tags when being connected to accounting integration
2. You can still add/ delete taxes when being connected to accounting integration

Did you test on dev/main, yeah? If so, @hayata-suenaga what did your PR for #41274 implement?

Should taxes, etc. be read-only when we are connected to accounting integration(with or without clicking import) or when we are connected to accounting integration AND clicking on import taxes, etc

Can you rephrase the question, I'm not sure I'm following you.

[trjExpensify]

All good, thanks! Assigning @hungvu193 to review.

[joekaufmanexpensify]

PRs are merged but not yet deployed

[joekaufmanexpensify]

PR on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make taxes read-only when connected to accounting integration #42192
• Fix taxes not blocked with accounting integration connected #42461

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment (Needs manual offer from BZ)
• @SzymczakJ does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[joekaufmanexpensify]

We already have a centralized testing script for this project, so IDT we need an ad-hoc regression test here.

[joekaufmanexpensify]

@SzymczakJ is with SWM, so only payment needed here is $250 to @hungvu193 for C+ review via Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bf513d396cfd4d35

[melvin-bot]

Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.

[hungvu193]

Hey @joekaufmanexpensify , I got paid already so no payment needed here 😄

[joekaufmanexpensify]

Ah, okay, sounds good! Just withdrew the upwork offer and closed the upwork job.

[joekaufmanexpensify]

In that case, we should be all set here then. Thanks everyone!