Web - Expense - Default tax rate and first tag item are not highlighted

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Tag and Tax features should be enabled in the workspace

1. Navigate to a workspace chat
2. Click on '+' > 'Request money' > 'Manual' > Enter amount & click 'Next'
3. Click on 'Show more' > 'Tag' > back navigate > click on 'Tax'

Expected Result:

Highlight should be applied to the first item on 'Tag' and the default tax option

Actual Result:

Highlight is not applied to the first item on 'Tag' and the default tax option

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6442289_1712582087068.Screen_Recording_2024-04-08_at_4.10.30_in_the_afternoon.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ghost]

I think it is caused by this PR and also over here for Tag :

App/src/components/TagPicker/index.tsx

Line 103 in c36442b

initiallyFocusedOptionKey={selectedOptionKey}

we haven't defined it as undefined and also here :

App/src/components/TagPicker/index.tsx

Line 92 in c36442b

const selectedOptionKey = sections[0]?.data?.filter((policyTag) => policyTag.searchText === selectedTag)?.[0]?.keyForList;

we haven't used useMemo as we have done it in here :

App/src/components/CategoryPicker.tsx

Line 73 in c36442b

const selectedOptionKey = useMemo(() => (sections?.[0]?.data ?? []).filter((category) => category.searchText === selectedCategory)[0]?.keyForList, [sections, selectedCategory]);

[luacmartins]

I don't think this is a blocker. However we should fix this. cc @teneeto @rezkiy37 @alitoshmatov @MonilBhavsar since it seems to come from #33927. @teneeto can you work on a fix please?

[MonilBhavsar]

Yes, I can assign so we can handle it

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@luacmartins, @MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MonilBhavsar]

Tax is fixed with TS migration PR. Will fix for tags

[MonilBhavsar]

When creating a new money request, category and tag are not selected by default. Tax is selected by default.
When clicking on category or tag, none of the item(first or selected) from TagPicker or CategoryPicker is highlighted
When clicking on tax, the default taxRate is highlighted.
So, this is working as expected!

Screen.Recording.2024-04-12.at.6.27.09.PM.mov