Tax and tax amount are updated little bit delayed in transaction thread page.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.60-13
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Found when executing PR : #39638
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:
User is an employee of Collect workspace that has taxes.Set few tax rates 5%, 10%,0% etc

1. Go to https://staging.new.expensify.com/
2. Go to workspace chat.
3. Create a manual request with tax that is not 0%.
   4.Quickly go to transaction thread

Expected Result:

Tax and tax amount must be updated without delay in transaction thread page.

Actual Result:

Tax and tax amount are updated in a little bit delayed way in transaction thread page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6440019_1712389315629.poooo.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@laurenreidexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[Julesssss]

Not ideal, but this doesn't need to be a deploy blocker. Checked it off

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax and tax amount are updated in a little bit delayed way in transaction thread page.

What is the root cause of that problem?

We don't pass the taxCode and taxAmount to getMoneyRequestInformation function to build the optimistic transaction so tax and taxAmount are only displayed when the RequestMoney API is complete

App/src/libs/actions/IOU.ts

Line 2079 in ce06355

function requestMoney(

What changes do you think we should make in order to solve the problem?

We should accept passing taxCode and taxAmount into getMoneyRequestInformation function and use it to build the optimistic transaction. So the tax and taxAmount can be displayed immediately when the request is created.

What alternative solutions did you explore? (Optional)

NA

[nkdengineer]

@Julesssss What do you think about my proposal? I can raise the PR to fix this issue ASAP if my proposal is selected.

[Julesssss]

@laurenreidexpensify and @techievivek will perform initial triage before we open it up for contributors, but that shouldn't take long 👍

[MonilBhavsar]

Dupe of #39615

[techievivek]

Great, going to close it out then, thanks.