-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search - Created task not displayed in search results until page refreshed #39705
Comments
Triggered auto assignment to @johnmlee101 ( |
We think that this bug might be related to #vip-vsb |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I dont think this has to be a blocker as its a quite specific flow I believe its coming from #38207 cc @TMisiukiewicz can you have a look please |
@mountiny yes please assign me 🙏 |
I can take over here @johnmlee101 if you dont mind |
Triggered auto assignment to @JmillsExpensify ( |
I already found what is causing the issue - the cached list is updated when a single reports updates, but it does not have a mechanism of creating a new option when a new item is created. I need some more time to figure out how to implement it and not downgrade the performance, going to continue working on that Monday morning |
Opened a draft PR, however reassure test was failing - I'm looking into that before opening |
Found one more related issue when requesting/sending money from non-existing account, gonna fix it with the same PR |
@mountiny I just opened the PR - the issue I had with non-existing account seem to not be related to my recent changes. I was trying to figure out if invited accounts are displayed on the search (the answer is yes), but I have encountered a weird behavior. After requesting money from non-existing account, the report opens with an e-mail address visible. After getting a response from API it changes to "Hidden". After refreshing the app, the email is visible again. I tried to track which change caused it, and noticed on version 1.4.60 it still works fine, but it happens on 1.4.61. Is this a known issue? |
I am not aware of this issue, could you report it in the open source channel please 🙏 |
This issue has not been updated in over 15 days. @JmillsExpensify, @TMisiukiewicz, @mountiny, @thesahindia eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
What's the latest on this issue? |
@JmillsExpensify it was fixed in #39811 |
Ah perfect. So all that is left is a payment summary: $250 to @thesahindia for PR review and testing. I'm closing this issue as C+ is paid out via New Expensify. @thesahindia make sure to comment on whether a regression test is needed when you request payment. Thanks! |
I think it's quite specific, so I don't think we need a test case. |
Payment Summary C+ @thesahindia $250 please request in newdot |
$250 approved for @thesahindia |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.60-8
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4478317
Issue reported by: Applause - Internal Team
Action Performed:
and log in
Expected Result:
The task is displayed in the search results
Actual Result:
The task is not displayed in the search results until the page is refreshed
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6438806_1712295173562.Recording__379.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: