-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payment due 2024-03-15][$250] [Mentions v2] Handle the new action type ACTIONABLEREPORTMENTIONWHISPER #39546
Comments
@rlinoz Do we have any specific ETA which we are aiming for with this one? |
I didn't start the backend changes for this one yet, but ideally we would get this done before May 1st. |
Great, ping me when backend would be ready - I'll then start this task |
Hey @robertKozik do you think you can start on this? I started the backend already and as we were talking here this is the order we want to get this deployed to avoid any trouble:
It will be a little harder to test, but I think we can manage. |
Also updated the action to be |
Triggered auto assignment to @kadiealexander ( |
|
Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify ( |
Looks like there's mocks in the doc, but happy to help. Is there anything needed from a design side on this? 😄 |
Oh I don't think so, it is just the new feature label I guess |
Hey @kadiealexander this is in prod already, but I don't know how we create the Upwork job in new feature issues, can you help please? |
Job added to Upwork: https://www.upwork.com/jobs/~01e95bf52a9e340f42 |
Current assignees @fedirjh and @ishpaul777 are eligible for the External assigner, not assigning anyone new. |
Payouts due:
Upwork job is here. |
hey! @kadiealexander this issue might be eligible for previous $500 bounty since this was created before April 5 https://expensify.slack.com/archives/C02NK2DQWUX/p1715196549664219?thread_ts=1715190852.677769&cid=C02NK2DQWUX |
HOLD #39508When a user that is member of the policy tries to mention a room that doesn't exist we will send a whisper back asking if they want to create the room they just mentioned, this whisper type will be
ACTIONABLEREPORTMENTIONWHISPER
.Resolving the whisper will call the
ResolveActionableReportMentionWhisper
command with areportActionID
and aresolution
, which can beyes
orno
. ThereportActionID
is the one of the whisper.If the whisper is resolved it should not be displayed to the user.
The whisper message will be:
reportNames[0]
doesn't exist yet. Do you want to create it?"reportNames[0]
andreportNames[1]
don't exist yet. Do you want to create them?"reportNames[0]
,reportNames[1]
andreportNames[2]
don't exist yet. Do you want to create them?"Details can be found here in the Mentions V2 design doc.
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @kadiealexanderThe text was updated successfully, but these errors were encountered: