Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment due 2024-03-15][$250] [Mentions v2] Handle the new action type ACTIONABLEREPORTMENTIONWHISPER #39546

Closed
rlinoz opened this issue Apr 3, 2024 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Apr 3, 2024

HOLD #39508

When a user that is member of the policy tries to mention a room that doesn't exist we will send a whisper back asking if they want to create the room they just mentioned, this whisper type will be ACTIONABLEREPORTMENTIONWHISPER .

Resolving the whisper will call the ResolveActionableReportMentionWhisper command with a reportActionID and a resolution, which can be yes or no. The reportActionID is the one of the whisper.

If the whisper is resolved it should not be displayed to the user.

The whisper message will be:

  • For a single room: "Heads up, reportNames[0] doesn't exist yet. Do you want to create it?"
  • For two rooms: "Heads up, reportNames[0] and reportNames[1] don't exist yet. Do you want to create them?"
  • For three or more: "Heads up, reportNames[0], reportNames[1] and reportNames[2] don't exist yet. Do you want to create them?"

Details can be found here in the Mentions V2 design doc.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e95bf52a9e340f42
  • Upwork Job ID: 1789790273655398400
  • Last Price Increase: 2024-05-12
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @kadiealexander
@rlinoz rlinoz changed the title [Mentions v2] Handle the new action type ACTIONABLEROOMMENTIONWHISPER [HOLD Mentions v2] Handle the new action type ACTIONABLEROOMMENTIONWHISPER Apr 3, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 8, 2024
@robertKozik
Copy link
Contributor

@rlinoz Do we have any specific ETA which we are aiming for with this one?

@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 22, 2024

I didn't start the backend changes for this one yet, but ideally we would get this done before May 1st.

@robertKozik
Copy link
Contributor

Great, ping me when backend would be ready - I'll then start this task

@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 29, 2024

Hey @robertKozik do you think you can start on this? I started the backend already and as we were talking here this is the order we want to get this deployed to avoid any trouble:

  1. Deploy the front-end to support showing the whisper
  2. Deploy the front-end to support resolving the whisper
  3. Deploy the back-end to support sending the whisper and handling its resolution

It will be a little harder to test, but I think we can manage.

@rlinoz rlinoz changed the title [HOLD Mentions v2] Handle the new action type ACTIONABLEROOMMENTIONWHISPER [Mentions v2] Handle the new action type ACTIONABLEROOMMENTIONWHISPER Apr 30, 2024
@rlinoz rlinoz changed the title [Mentions v2] Handle the new action type ACTIONABLEROOMMENTIONWHISPER [Mentions v2] Handle the new action type ACTIONABLEREPORTMENTIONWHISPER Apr 30, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 30, 2024

Also updated the action to be ACTIONABLEREPORTMENTIONWHISPER

@rlinoz rlinoz added the NewFeature Something to build that is a new item. label Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Apr 30, 2024
Copy link

melvin-bot bot commented Apr 30, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Apr 30, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@dubielzyk-expensify
Copy link
Contributor

Looks like there's mocks in the doc, but happy to help. Is there anything needed from a design side on this? 😄

@rlinoz
Copy link
Contributor Author

rlinoz commented May 1, 2024

Oh I don't think so, it is just the new feature label I guess

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels May 1, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented May 10, 2024

Hey @kadiealexander this is in prod already, but I don't know how we create the Upwork job in new feature issues, can you help please?

@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label May 12, 2024
Copy link

melvin-bot bot commented May 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e95bf52a9e340f42

@melvin-bot melvin-bot bot changed the title [Mentions v2] Handle the new action type ACTIONABLEREPORTMENTIONWHISPER [$250] [Mentions v2] Handle the new action type ACTIONABLEREPORTMENTIONWHISPER May 12, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 12, 2024
Copy link

melvin-bot bot commented May 12, 2024

Current assignees @fedirjh and @ishpaul777 are eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 12, 2024
@kadiealexander kadiealexander changed the title [$250] [Mentions v2] Handle the new action type ACTIONABLEREPORTMENTIONWHISPER [Payment due 2024-03-15][$250] [Mentions v2] Handle the new action type ACTIONABLEREPORTMENTIONWHISPER May 12, 2024
@kadiealexander
Copy link
Contributor

kadiealexander commented May 15, 2024

Payouts due:

Upwork job is here.

@kadiealexander kadiealexander added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review Help Wanted Apply this label when an issue is open to proposals by contributors labels May 15, 2024
@ishpaul777
Copy link
Contributor

hey! @kadiealexander this issue might be eligible for previous $500 bounty since this was created before April 5 https://expensify.slack.com/archives/C02NK2DQWUX/p1715196549664219?thread_ts=1715190852.677769&cid=C02NK2DQWUX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

6 participants