Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mentions v2] Apply style to <mention-report> tag in the Composer #39542

Closed
rlinoz opened this issue Apr 3, 2024 · 21 comments
Closed

[Mentions v2] Apply style to <mention-report> tag in the Composer #39542

rlinoz opened this issue Apr 3, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Apr 3, 2024

HOLD #39538

When typing in the composer we need to be able to highlight room mentions, the same way we do for user mentions, so we need to update the react-native-live-markdown library to understand the <mention-report> tag.

After updating the library we need to use the change in App and style the mention accordingly. The style will be the same we use for user mentions.

Details can be found here in the Mentions V2 design doc.

Issue OwnerCurrent Issue Owner: @dylanexpensify
@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 8, 2024
@robertKozik
Copy link
Contributor

Hi @rlinoz, this will be next in line for me. Can you assign me to this?

@rlinoz rlinoz added the NewFeature Something to build that is a new item. label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @dylanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 10, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@melvin-bot melvin-bot bot removed the Monthly KSv2 label Apr 10, 2024
@rlinoz rlinoz added Daily KSv2 and removed Weekly KSv2 labels Apr 10, 2024
@rlinoz rlinoz changed the title [HOLD Mentions v2] Apply style to <mention-report> tag in the Composer [Mentions v2] Apply style to <mention-report> tag in the Composer Apr 10, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 12, 2024

Hey @robertKozik what is the ETA on this one?

@robertKozik
Copy link
Contributor

Hi, I'm aiming for the live-markdown PR by the EOD. PR for the E/App should be ready for review early next week (preferably on Monday)

@dylanexpensify
Copy link
Contributor

Wahooo!

@robertKozik
Copy link
Contributor

A little delay 🫣 Here is PR inside react-native-live-markdown library Expensify/react-native-live-markdown#310. Once merged I'll open PR inside E/App repo

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@dylanexpensify
Copy link
Contributor

Nice one!

@rlinoz rlinoz added Reviewing Has a PR in review and removed Reviewing Has a PR in review labels Apr 15, 2024
@rlinoz rlinoz self-assigned this Apr 15, 2024
@robertKozik
Copy link
Contributor

Posted draft PR - currently working on recording videos, should be ready for review today

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Apr 16, 2024
Copy link

melvin-bot bot commented Apr 18, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rlinoz rlinoz added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Apr 22, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 22, 2024

Deployed to prod

@dylanexpensify
Copy link
Contributor

Wahoo! Waiting for regression period

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Apr 29, 2024
@dylanexpensify
Copy link
Contributor

Same

@c3024
Copy link
Contributor

c3024 commented May 1, 2024

@dylanexpensify Regression period completed, right? PR deployed to prod 9 days ago. : 🤔

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented May 6, 2024

Friendly bump @dylanexpensify

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 6, 2024
@dylanexpensify
Copy link
Contributor

Ahh, weird it didn't update! Sorry about that! Will pay today

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@dylanexpensify
Copy link
Contributor

Payment summary:

Please request or apply here!

@c3024
Copy link
Contributor

c3024 commented May 8, 2024

@dylanexpensify thanks, applied. Here is my Upwork profile link as well for reference.
https://www.upwork.com/freelancers/~0105555e2f227dbf47

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@dylanexpensify
Copy link
Contributor

@c3024 sent offer!

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
@c3024
Copy link
Contributor

c3024 commented May 14, 2024

@dylanexpensify accepted, thanks!

@dylanexpensify
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

4 participants