-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mentions v2] Apply style to <mention-report> tag in the Composer #39542
Comments
Hi @rlinoz, this will be next in line for me. Can you assign me to this? |
Triggered auto assignment to @dylanexpensify ( |
|
Hey @robertKozik what is the ETA on this one? |
Hi, I'm aiming for the live-markdown PR by the EOD. PR for the E/App should be ready for review early next week (preferably on Monday) |
Wahooo! |
A little delay 🫣 Here is PR inside |
Nice one! |
Posted draft PR - currently working on recording videos, should be ready for review today |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Deployed to prod |
Wahoo! Waiting for regression period |
Same |
@dylanexpensify Regression period completed, right? PR deployed to prod 9 days ago. : 🤔 |
Friendly bump @dylanexpensify |
Ahh, weird it didn't update! Sorry about that! Will pay today |
Payment summary:
Please request or apply here! |
@dylanexpensify thanks, applied. Here is my Upwork profile link as well for reference. |
@c3024 sent offer! |
@dylanexpensify accepted, thanks! |
Done! |
HOLD #39538When typing in the composer we need to be able to highlight room mentions, the same way we do for user mentions, so we need to update the
react-native-live-markdown
library to understand the<mention-report>
tag.After updating the library we need to use the change in App and style the mention accordingly. The style will be the same we use for user mentions.
Details can be found here in the Mentions V2 design doc.
Issue Owner
Current Issue Owner: @dylanexpensifyThe text was updated successfully, but these errors were encountered: