-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Live markdown for workspace description #39193
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01feb88466d128ac03 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Triggered auto assignment to @twisterdotcom ( |
|
I'd like to work on this if it's open for contributors 👍 ProposalPlease re-state the problem that we are trying to solve in this issue.No live markdown formatting currently for workspace description What is the root cause of that problem?This is new feature. What changes do you think we should make in order to solve the problem?Use What alternative solutions did you explore? (Optional)NA |
Upwork job price has been updated to $250 |
@nkdengineer friendly piece of feedback: please take the time you need to add a bit of detail to the proposal. The practice of "speedrun" proposals where you post quickly then edit it incrementally isn't something I like to see |
📣 @nkdengineer You have been assigned to this job! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Live markdown for workspace description What is the root cause of that problem?New feature What changes do you think we should make in order to solve the problem?To fix this issue we can need make some changes For details page we use App/src/pages/iou/request/step/IOURequestStepDescription.js Lines 191 to 209 in c64770e
So we need change InputComponent={TextInput} to InputComponent={RNMarkdownTextInput} What alternative solutions did you explore? (Optional)NA |
Also note that we should wait for live markdown web to land on production before merging a PR here |
@roryabraham Thanks for the feedback! I'll take note of it 🙏 |
I can see the proposal was already accepted and @nkdengineer was assigned. @roryabraham Do we want to hold the issue by linking the live markdown issue here? |
@mananjadhav The PR is here #39686. |
Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
This issue has not been updated in over 15 days. @mananjadhav, @twisterdotcom, @blimpich, @nkdengineer eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@twisterdotcom This is ready for payout. This is a feature request and hence doesn't have an offending PR. But I think we should copy the Test steps from the PR as regression steps? |
Sorry it seems the automation didn't work. Payment should be out shortly. 👍 cc: @twisterdotcom |
Okay, payouts just $250 for @mananjadhav and @nkdengineer right? |
Yes @twisterdotcom |
$250 approved for @mananjadhav |
Payment Summary:
|
@twisterdotcom Not fair!! $250 for me and $2500 for @nkdengineer ? 🤣 🤣 |
💰🤑💸 |
😂 wooops. Just had to check the contract too make sure I didn't mess that one up too. Just a typo! |
@twisterdotcom Offer accepted 🙏 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1711641837108169
Action Performed:
Expected Result:
The markdown styling should render in real-time, as it does for the main chat composer.
Actual Result:
No live markdown formatting.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: