Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Live markdown for workspace description #39193

Closed
6 tasks done
roryabraham opened this issue Mar 28, 2024 · 25 comments
Closed
6 tasks done

[$250] Live markdown for workspace description #39193

roryabraham opened this issue Mar 28, 2024 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Mar 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1711641837108169

Action Performed:

  1. Create a workspace if you don't already have one
  2. Open workspace settings
  3. Click on the input for workspace description and start typing markdown in there

image

Expected Result:

The markdown styling should render in real-time, as it does for the main chat composer.

Actual Result:

No live markdown formatting.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01feb88466d128ac03
  • Upwork Job ID: 1773388688826933248
  • Last Price Increase: 2024-03-28
Issue OwnerCurrent Issue Owner: @twisterdotcom
@roryabraham roryabraham added External Added to denote the issue can be worked on by a contributor Daily KSv2 NewFeature Something to build that is a new item. labels Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01feb88466d128ac03

@melvin-bot melvin-bot bot changed the title Live markdown for workspace description [$500] Live markdown for workspace description Mar 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

Copy link

melvin-bot bot commented Mar 28, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@roryabraham roryabraham moved this to Todo in Live Markdown Mar 28, 2024
@roryabraham roryabraham changed the title [$500] Live markdown for workspace description [$250] Live markdown for workspace description Mar 28, 2024
@nkdengineer
Copy link
Contributor

nkdengineer commented Mar 28, 2024

I'd like to work on this if it's open for contributors 👍

Proposal

Please re-state the problem that we are trying to solve in this issue.

No live markdown formatting currently for workspace description

What is the root cause of that problem?

This is new feature.

What changes do you think we should make in order to solve the problem?

Use RNMarkdownTextInput, just like we're doing for Composer here, we'll need to apply it to the workspace description input here, additional style changes will be needed.

What alternative solutions did you explore? (Optional)

NA

Copy link

melvin-bot bot commented Mar 28, 2024

Upwork job price has been updated to $250

@roryabraham
Copy link
Contributor Author

roryabraham commented Mar 28, 2024

@nkdengineer friendly piece of feedback: please take the time you need to add a bit of detail to the proposal. The practice of "speedrun" proposals where you post quickly then edit it incrementally isn't something I like to see

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 28, 2024
Copy link

melvin-bot bot commented Mar 28, 2024

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@ZhenjaHorbach
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Live markdown for workspace description

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

To fix this issue we can need make some changes

For details page we use InputWrapperWithRef

<InputWrapperWithRef
InputComponent={TextInput}
inputID={INPUT_IDS.MONEY_REQUEST_COMMENT}
name={INPUT_IDS.MONEY_REQUEST_COMMENT}
defaultValue={currentDescription}
label={translate('moneyRequestConfirmationList.whatsItFor')}
accessibilityLabel={translate('moneyRequestConfirmationList.whatsItFor')}
role={CONST.ROLE.PRESENTATION}
ref={(el) => {
if (!el) {
return;
}
inputRef.current = el;
updateMultilineInputRange(inputRef.current);
}}
autoGrowHeight
containerStyles={[styles.autoGrowHeightMultilineInput]}
shouldSubmitForm
/>

So we need change InputComponent={TextInput} to InputComponent={RNMarkdownTextInput}

What alternative solutions did you explore? (Optional)

NA

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 28, 2024
@roryabraham
Copy link
Contributor Author

Also note that we should wait for live markdown web to land on production before merging a PR here

@nkdengineer
Copy link
Contributor

@roryabraham Thanks for the feedback! I'll take note of it 🙏

@mananjadhav
Copy link
Collaborator

I can see the proposal was already accepted and @nkdengineer was assigned. @roryabraham Do we want to hold the issue by linking the live markdown issue here?

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 5, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 5, 2024
@nkdengineer
Copy link
Contributor

@mananjadhav The PR is here #39686.

Copy link

melvin-bot bot commented Apr 15, 2024

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 29, 2024
Copy link

melvin-bot bot commented Apr 29, 2024

This issue has not been updated in over 15 days. @mananjadhav, @twisterdotcom, @blimpich, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mananjadhav
Copy link
Collaborator

@twisterdotcom This is ready for payout. This is a feature request and hence doesn't have an offending PR.

But I think we should copy the Test steps from the PR as regression steps?

@blimpich blimpich added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Apr 29, 2024
@blimpich
Copy link
Contributor

Sorry it seems the automation didn't work. Payment should be out shortly. 👍

cc: @twisterdotcom

@twisterdotcom
Copy link
Contributor

Okay, payouts just $250 for @mananjadhav and @nkdengineer right?

@mananjadhav
Copy link
Collaborator

Yes @twisterdotcom

@JmillsExpensify
Copy link

$250 approved for @mananjadhav

@twisterdotcom
Copy link
Contributor

twisterdotcom commented May 3, 2024

Payment Summary:

@mananjadhav
Copy link
Collaborator

@twisterdotcom Not fair!! $250 for me and $2500 for @nkdengineer ? 🤣 🤣

@blimpich
Copy link
Contributor

blimpich commented May 3, 2024

💰🤑💸

@twisterdotcom
Copy link
Contributor

😂 wooops. Just had to check the contract too make sure I didn't mess that one up too. Just a typo!

@nkdengineer
Copy link
Contributor

@twisterdotcom Offer accepted 🙏

@thienlnam thienlnam moved this from Todo to Done in Live Markdown Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor Monthly KSv2 NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

7 participants