[HOLD for payment 2024-04-09] [HOLD for payment 2024-04-05] [$500] Shortcut - Error shows up when creating second self-assigned task via Assign task shortcut

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.57-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self-DM
3. Create a task and assigned to self
4. Go to FAB
5. Click Assign task shortcut
6. Create another task which is assigned to self

Expected Result:

The second task is created successfully

Actual Result:

Error shows up when creating the second task via Assign task shortcut. The current user mention in the task becomes Hidden

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428617_1711540650656.shortcut_task_self_DM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0116839472c268c287
• Upwork Job ID: 1773049601832173568
• Last Price Increase: 2024-03-27
• Automatic offers:
• ishpaul777 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@iwiznia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nexarvo]

Regression from #38669
For self DM, it is creating new optimistic report everytime task is created from Shortcut. It should not create new report but take the original self DM report. The issue is specifically here:

App/src/libs/actions/Task.ts

Lines 714 to 717 in b27be0f

	if (accountID > 0) {
	const accountLogin = allPersonalDetails?.[accountID]?.login ?? '';
	setAssigneeValue(accountLogin, accountID, reportID);
	}

Due to new optimistic report, the backend is sending error:

Mismatch in reportID:

[melvin-bot]

📣 @nexarvo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error shows up when creating second self-assigned task via Assign task shortcut

What is the root cause of that problem?

We are getting chat report by participant lists here:

App/src/libs/ReportUtils.ts

Line 4447 in f8416e9

return lodashIsEqual(sortedNewParticipantList, report.participantAccountIDs?.sort());

This returns the first matched record. (BTW sometime we have more than one chat report selected in this function but it return the first one). Which might not be the exact report we want. In current issue the same problem is happening that it is selecting wrong report in above function.

What changes do you think we should make in order to solve the problem?

We already have chat ID here:

App/src/libs/actions/Task.ts

Lines 714 to 717 in b27be0f

	if (accountID > 0) {
	const accountLogin = allPersonalDetails?.[accountID]?.login ?? '';
	setAssigneeValue(accountLogin, accountID, reportID);
	}

We can use this chat ID to get the report. This way we will have the exact report which we want. Right now In ReportUtils.ts we don't have any function to get report by ReportID. We can create one:

function getChatByReportID(reportID: string) {
    return allReports.find(report => report. reportID = reportID);
}

We will call the new function in place of this function:

App/src/libs/actions/Task.ts

Line 656 in f8416e9

chatReport = ReportUtils.getChatByParticipants([assigneeAccountID]);

Like this:

chatReport = getChatByReportID(reportID); 

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0116839472c268c287

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[iwiznia]

Looks good to me

[melvin-bot]

The BZ member will need to manually hire nexarvo for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[nexarvo]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b5c4ee99eace8e60

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/39049 shortcut self dm task #39215

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @nexarvo requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/39049 shortcut self dm task #39215

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @nexarvo requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

There was a regression from the linked PR. The new PR to fix that regression is here: #39328. We'll wait for that to be deployed before paying this one out.

[ishpaul777]

still held on regression fix prod deployment

[nexarvo]

@sakluger can we proceed with payments here as the regression from this issue was fixed and deployed to prod. The issue for the regression is also closed #39260

[nexarvo]

@sakluger I think this is a $500 ticket as this was made external before we made standard as $250. The amount is also mentioned in the title.

[sakluger]

Thanks for the heads up @nexarvo! The base price is $500, but we cut it in half when there is a regression.

Summarizing payment on this issue:

Contributor: @nexarvo $250 (50% reduction for regression), sent offer via Upwork
Contributor+: @ishpaul777 $250 (50% reduction for regression) paid via Upwork

[sakluger]

All paid, thanks everyone