-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-15] Live Markdown Composer Issues #39006
Comments
1st & 2nd are likely related to the issue mentioned, we're not sure about the 3rd bug @Skalakid is investigating that one. I already have a fix ready for the 4th bug, but I'm still testing it - this is a problem with styles in the Expensify App |
Fixed ✅ |
Merging this into the main tracking issue now that this is merged! #36071 |
Hi @thienlnam, I prepared the PR that fixes:
|
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-15. 🎊 |
Coming from this PR, there's a few scrolling / cursor issues that come from how we're handling text & linebreaks
The main issue that should fix all of those is Expensify/react-native-live-markdown#239
We're just going to keep tracking all the issues that come up in this main tracking issue
There is unused space in the composer when expanding the composer (The scroll does not extend throughout the composer height when clicked on the expand icon on the top left of the composer)The text was updated successfully, but these errors were encountered: