Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-15] Live Markdown Composer Issues #39006

Closed
thienlnam opened this issue Mar 26, 2024 · 7 comments
Closed

[HOLD for payment 2024-04-15] Live Markdown Composer Issues #39006

thienlnam opened this issue Mar 26, 2024 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Mar 26, 2024

Coming from this PR, there's a few scrolling / cursor issues that come from how we're handling text & linebreaks

The main issue that should fix all of those is Expensify/react-native-live-markdown#239

We're just going to keep tracking all the issues that come up in this main tracking issue

  • Pasting text introduces extra line breaks between paragraphs
  • The cursor is jumping weirdly when navigating through keyboard on quoted blocks
  • When I paste large text with a mention in it the cursor gets placed inside the mention instead of the end of the text
  • There is unused space in the composer when expanding the composer (The scroll does not extend throughout the composer height when clicked on the expand icon on the top left of the composer)
@thienlnam thienlnam added the Weekly KSv2 label Mar 26, 2024
@thienlnam thienlnam self-assigned this Mar 26, 2024
@BartoszGrajdek
Copy link
Contributor

1st & 2nd are likely related to the issue mentioned, we're not sure about the 3rd bug @Skalakid is investigating that one. I already have a fix ready for the 4th bug, but I'm still testing it - this is a problem with styles in the Expensify App

@BartoszGrajdek
Copy link
Contributor

There is unused space in the composer when expanding the composer (The scroll does not extend throughout the composer height when clicked on the expand icon on the top left of the composer)

Fixed ✅

@thienlnam
Copy link
Contributor Author

Merging this into the main tracking issue now that this is merged! #36071

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 28, 2024
@Skalakid
Copy link
Contributor

Hi @thienlnam, I prepared the PR that fixes:

  • Pasting text introduces extra line breaks between paragraphs
  • When I paste large text with a mention in it the cursor gets placed inside the mention instead of the end of the text

Copy link

melvin-bot bot commented Mar 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot changed the title Live Markdown Composer Issues [HOLD for payment 2024-04-15] Live Markdown Composer Issues Apr 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Apr 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-15. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants