payment due [$500] Image MD - LHN preview shows "Attachment" instead of "Text [Attachment]" after reopening chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause - Internal Team

Issue found when executing PR #37566

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message with inline image markdown. Example:
   An inline image and some text
4. Go to a different chat
5. Go back to the chat in Step 3

Expected Result:

LHN preview will show "text [Attachment]" format after returning to the same chat

Actual Result:

LHN preview shows "Attachment" instead of "text [Attachment]" after returning to the same chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6424057_1711172686157.20240323_133419.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ccedd73b162426f
• Upwork Job ID: 1774996577371983872
• Last Price Increase: 2024-04-02
• Automatic offers:
• shubham1206agra | Reviewer | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@marcochavezf FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Image MD - LHN preview shows "Attachment" instead of "Text [Attachment]" after reopening chat

What is the root cause of that problem?

• In offline mode, the last message is displayed as "text (image of ${image-name})". It is because the last message text is from here, where we use parser.htmlToText(htmlForNewComment), that will replace image tag with (image of $4)
• In online mode, BE return [Attachment] instead of text [Attachment]

What changes do you think we should make in order to solve the problem?

• We need to update this to:

                replacement: '[Attachment]',

• Then, BE need to change based on it for consistency

What alternative solutions did you explore? (Optional)

• NA

[marcochavezf]

Looks like inline image markdown is not live on production yet, so it's a new feature:

[marcochavezf]

Ah yes, this is the PR that introduced the new functionality, removing the deploy blocker label

[marcochavezf]

Applying External and Bug labels

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011ccedd73b162426f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[zanyrenney]

Seeing as this relates to chat primarily, have added to VIP VSB.

[marcochavezf]

Sounds good, thanks @shubham1206agra for the review, assigning @nkdengineer for the frontend part

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@marcochavezf, @zanyrenney, @shubham1206agra, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[zanyrenney]

any updates here @marcochavezf @shubham1206agra @nkdengineer

[nkdengineer]

@zanyrenney Opened a PR in expensify-common here.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[zanyrenney]

Wait seven days for payout

[zanyrenney]

payment summary

paid 📣 @shubham1206agra 🎉 $500

@nkdengineer has not applied for the job so cannot be paid, i have asked them to apply in DM.

[melvin-bot]

@marcochavezf @zanyrenney @shubham1206agra @nkdengineer this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[nkdengineer]

@nkdengineer has not applied for the job so cannot be paid, i have asked them to apply in DM.

@zanyrenney I just applied for the job, thanks!!

[zanyrenney]

this is taking so long :( i've sent the offer again.

[nkdengineer]

@zanyrenney I've accepted the offer, sorry for the delay

[zanyrenney]

Thank you @nkdengineer !

[zanyrenney]

Full payment summary:

payment summary

paid 📣 @shubham1206agra 🎉 $500 via Upwork

paid 📣 @nkdengineer 🎉 $500 via Upwork.