-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image MD - Download icon on image view from image mark down opens image in a new tab #38875
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @pecanoro ( |
We think that this bug might be related to #vip-vsp |
@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
This is expected behavior. |
I am not sure how to send an inline image with markdown, using this does not seem to work:
|
Ok, I checked the original PR and I think I was copying and pasting somehow in a strange way. I also check the original description and yeah, this is expected so closing |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.56-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Issue found when executing PR #37566
Action Performed:
An inline image and some text
Expected Result:
Clicking Download on image view from image mark down will show download destination prompt
Actual Result:
Clicking Download on image view from image mark down opens the image in another tab
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6424064_1711173893455.20240323_140041.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: