Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] IOU - IOU Detail Scrolls When Opened #38874

Closed
4 of 6 tasks
kbecciv opened this issue Mar 23, 2024 · 14 comments
Closed
4 of 6 tasks

[$500] IOU - IOU Detail Scrolls When Opened #38874

kbecciv opened this issue Mar 23, 2024 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Mar 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.56-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Click on FAB > Request Money.
  2. Navigate to Distance, add start and end points, then click Next.
  3. Select Workspace, then click on Request Money.
  4. Go to IOU and observe that the IOU detail is scrolled.

Expected Result:

The IOU detail should not scroll.

Actual Result:

The IOU detail is scrolled.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423967_1711160953526.Screen_Recording_2024-03-22_at_7.03.44_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01524a61d25a6420ab
  • Upwork Job ID: 1772482477086314496
  • Last Price Increase: 2024-03-26
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Mar 23, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 23, 2024

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@kbecciv
Copy link
Author

kbecciv commented Mar 23, 2024

We think that this bug might be related to #vip-vsb

@stitesExpensify
Copy link
Contributor

To be clear, the problem isn't that the page is "Scrolling", it's that there is no top margin so the button in the top left can't be clicked, right?

@stitesExpensify
Copy link
Contributor

And if that is the case, how does that work on desktop?

@yuwenmemon yuwenmemon added Daily KSv2 Hourly KSv2 Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Mar 26, 2024
Copy link

melvin-bot bot commented Mar 26, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Mar 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01524a61d25a6420ab

@melvin-bot melvin-bot bot changed the title IOU - IOU Detail Scrolls When Opened [$500] IOU - IOU Detail Scrolls When Opened Mar 26, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 26, 2024
Copy link

melvin-bot bot commented Mar 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

@yuwenmemon
Copy link
Contributor

As discussed here, no longer considering this a blocker: https://expensify.slack.com/archives/C01GTK53T8Q/p1711394680384129

@ghost
Copy link

ghost commented Mar 26, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: v1.4.56-0 Reproducible in staging?: y Reproducible in production?: n Issue reported by: Applause - Internal Team

Action Performed:

  1. Click on FAB > Request Money.
  2. Navigate to Distance, add start and end points, then click Next.
  3. Select Workspace, then click on Request Money.
  4. Go to IOU and observe that the IOU detail is scrolled.

Expected Result:

The IOU detail should not scroll.

Actual Result:

The IOU detail is scrolled.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423960_1711160389870.video_2024-03-22_22-11-05.mp4
View all open jobs on GitHub

Upwork Automation - Do Not Edit

I think the video attached for this issue, seems to be different from steps to reproduce this issue. @yuwenmemon @stitesExpensify

@sonialiap
Copy link
Contributor

@kbecciv the video in this issue is about setting rates and doesn't match the steps that talk about creating a distance expense. Could you confirm whether the issue steps or the video needs updating, and update if necessary?

@kbecciv
Copy link
Author

kbecciv commented Mar 29, 2024

Checking @sonialiap

@kbecciv
Copy link
Author

kbecciv commented Mar 29, 2024

@sonialiap Updated the video, sorry for confusion!

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@sonialiap
Copy link
Contributor

sonialiap commented Apr 1, 2024

This scrolling behavior does not impact usability so I don't think this is an issue. Please reopen if you disagree

Screen.Recording.2024-04-01.at.1.45.32.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

5 participants