[HOLD for payment 2024-06-06] [Awaiting NewDot Request] [$250] [Simplified Collect][Tags] - Error when deleting dependent tags and unable to dismiss the error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is admin of Collect workspace
• The Collect workspace has multilevel dependent tags

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > Collect workspace
3. Go to Tags
4. Click on the first level tag (California)
5. Click 3-dot menu > Delete tag
6. Delete the tag

Expected Result:

User will be able to delete the tag

Actual Result:

Error shows up when deleting the first level tag. The error cannot be dimissed by clicking X

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6420680_1710950420152.20240320_234913.mp4

Bug6420680_1710950420154!Dependent_-_Multi_Level_tags_NEW.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017bf91552e94657a4
• Upwork Job ID: 1784921028579934208
• Last Price Increase: 2024-04-29
• Automatic offers:
• gijoe0295 | Contributor | 0

Issue Owner

Current Issue Owner: @garrettmknight

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave-control

[lanitochka17]

@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[deetergp]

I can't reproduce this locally 🤔 Collect policies are beta / not available to the public, so I don't think this is a blocker.

Update: After re-reading the description, I realized we were talking about dependent tags and not just regular old tags. My bad 😅

[deetergp]

This PR is the culprit #38453

[luacmartins]

cc @allroundexperts

[deetergp]

Not overdue. This PR should take care of it #38759

[melvin-bot]

@deetergp, @luacmartins, @allroundexperts Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[deetergp]

Still waiting on that PR.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @garrettmknight you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[garrettmknight]

Payment Summary:

• Contributor: @gijoe0295 $250 paid in Upwork
• Reviewer: @allroundexperts $250

[garrettmknight]

@allroundexperts can you complete the checklist when you get a chance and request payment?

[allroundexperts]

Checklist

1. Add tag delete option #38453
2. This was a deploy blocker and is clearly mentioned in the PR that caused it.
3. N/A
4. The steps given in OP look simple enough to me.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• hide delete option in multi tag view #42124

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @gijoe0295 requires payment automatic offer (Contributor)

[garrettmknight]

Already added payment summary - just need @allroundexperts to request payment in ND.

[garrettmknight]

Just waiting on ND payment.

[deetergp]

Still waiting on ND payments?

[garrettmknight]

Yep!

[luacmartins]

Bump @allroundexperts for payment request! 🤑

[allroundexperts]

Hi @luacmartins!

I have this noted down. Please feel free to close.

[JmillsExpensify]

$250 approved for @allroundexperts