Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-28] [Payment card / Subscription] Integrate “Subscription settings” section with backend data #38627

Closed
MitchExpensify opened this issue Mar 19, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Mar 19, 2024

Covers this section of the doc: https://docs.google.com/document/d/1jXV_vIsOGZuL0dMiuXDWRETAFRX64ODVAhWPtiuFXT8/edit?pli=1#bookmark=id.fwc9tpz3pb79

cc @fabioh8010

@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 5, 2024
@trjExpensify trjExpensify moved this from Release 2: Summer 2024 (Aug) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 17, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Overdue label Jun 4, 2024
@MitchExpensify
Copy link
Contributor Author

@fabioh8010 Can you help me update the body of this issue to reflect exactly which part of the doc it covers please? Thanks

@fabioh8010
Copy link
Contributor

fabioh8010 commented Jun 6, 2024

@MitchExpensify Is the section you linked in this GH issue, Implement “Subscription settings” section -> https://docs.google.com/document/d/1jXV_vIsOGZuL0dMiuXDWRETAFRX64ODVAhWPtiuFXT8/edit?pli=1#bookmark=id.fwc9tpz3pb79

@MitchExpensify
Copy link
Contributor Author

Cool so the body is linking to the correct section of the doc, just to be sure, right? @fabioh8010

@melvin-bot melvin-bot bot added the Overdue label Jun 10, 2024
@JKobrynski
Copy link
Contributor

I think it makes the most sense to implement all toggle actions as a part of this issue. Backend integration for that section would be a very tiny PR, like 2-3 lines of new code, so I think it would just bring more work for the reviewers to have 2 separate tasks. Wdyt? I'm already working on it and will be posting a PR soon

CC: @amyevans

@amyevans
Copy link
Contributor

Yep that sounds great! Thanks @JKobrynski!

@amyevans
Copy link
Contributor

Reassigning to @blimpich as I'm headed out on extended leave

@trjExpensify trjExpensify moved this from Release 1.5: XeroCon 2024 (June 12th) to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 21, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Integrate “Subscription settings” section with backend data [HOLD for payment 2024-06-28] [Payment card / Subscription] Integrate “Subscription settings” section with backend data Jun 21, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 21, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 28, 2024
Copy link

melvin-bot bot commented Jun 28, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
Copy link

melvin-bot bot commented Jul 1, 2024

@blimpich, @JKobrynski Whoops! This issue is 2 days overdue. Let's get this updated quick!

@trjExpensify
Copy link
Contributor

No BZ on this either. Payment summary as follows:

New feature, regression tests are going to be added centrally for the project as we wrap up soon.

I'll send you an offer on Upwork now.

@DylanDylann
Copy link
Contributor

@trjExpensify As this Slack thread,

Any issues created before this date will maintain their original stated price.

this issue was created on March 20 when the initial price still was 500$. Should we update the offer to increase the compensation?

@trjExpensify
Copy link
Contributor

Ah yeah, fair enough. Missed that. Accept and I'll adjust.

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2024
@DylanDylann
Copy link
Contributor

@trjExpensify Thanks 🙏 I accepted it

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 6, 2024
@trjExpensify
Copy link
Contributor

Paid, closing!

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants