Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription details” section (UI) #38623

Closed
MitchExpensify opened this issue Mar 19, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Mar 19, 2024

Complete the Create “Subscription details” section (UI) section of the design doc

Issue OwnerCurrent Issue Owner: @MitchExpensify
@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 5, 2024
@trjExpensify trjExpensify moved this from Release 2: Summer 2024 (Aug) to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 17, 2024
@melvin-bot melvin-bot bot added the Overdue label May 22, 2024
@amyevans amyevans added Daily KSv2 and removed Monthly KSv2 labels May 22, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 22, 2024
@amyevans amyevans self-assigned this May 22, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

@amyevans amyevans assigned JKobrynski and unassigned fabioh8010 May 23, 2024
@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@amyevans
Copy link
Contributor

Not overdue, next up for @JKobrynski

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 28, 2024
@amyevans
Copy link
Contributor

Per Slack from @JKobrynski:

most of the work is done, I've implemented the basic layout, added the new assets, created the new component, and now I'm working on the ExpensifyApproved variant, as well as the native version, so I might be able to publish a draft later today but more likely on Monday.

@JKobrynski
Copy link
Contributor

The PR is ready for review!

@amyevans amyevans added the NewFeature Something to build that is a new item. label Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@amyevans
Copy link
Contributor

amyevans commented Jun 7, 2024

@Ollyws reviewed the PR as C+ so will be due payment

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Implement “Subscription details” section (UI) [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription details” section (UI) Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment through NewDot Manual Requests
  • @JKobrynski does not require payment (Contractor)

Copy link

melvin-bot bot commented Jun 11, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Ollyws] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription details” section (UI) [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription details” section (UI) Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @Ollyws requires payment through NewDot Manual Requests
  • @JKobrynski does not require payment (Contractor)

Copy link

melvin-bot bot commented Jun 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Ollyws] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@MitchExpensify
Copy link
Contributor Author

Reminder set to pay

@trjExpensify trjExpensify moved this from Release 1.5: XeroCon 2024 (June 12th) to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 18, 2024
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 18, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

Payment Summary

Upwork Job

  • Reviewer: @Ollyws owed $250 via NewDot
  • Contributor: @JKobrynski is from an agency-contributor and not due payment

BugZero Checklist (@MitchExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@MitchExpensify
Copy link
Contributor Author

MitchExpensify commented Jun 21, 2024

Payment summary:

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jun 22, 2024
@Ollyws
Copy link
Contributor

Ollyws commented Jun 24, 2024

Requested payment in ND.

@JmillsExpensify
Copy link

$250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

6 participants