[$500] [HOLD for payment 2024-03-26] [Simplified Collect][Categories] - App crashes when selecting categories and editing category name at the same time

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.53-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an admin of Collect workspace
• The Collect workspace has several categories

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > any workspace
3. Go to Categories
4. Check Select all checkbox
5. Click on any category
6. Click Category name
7. Edit the name and save it

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6415046_1710514615236.20240315_224432.mp4

log.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0197c3d60db95d1c51
• Upwork Job ID: 1775479164031770624
• Last Price Increase: 2024-04-03

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@amyevans FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control
CC @jason

[lanitochka17]

Production:

bandicam.2024-03-15.17-47-23-854.mp4

[situchan]

@FitseTLT are you able to reproduce on production? Looks like you pointed out PR which was deployed to production 2 weeks ago as offending one.

[c3024]

EditCategoryPage was not deployed to production yet. So this cannot be reproduced on prod.

I think disabling editing of a category when it is selected is more appropriate or use a key other than category name that does not change when a category name is changed.

cc: @ArekChr @luacmartins

[amyevans]

Looks like the ability to edit was introduced in #37969. @ArekChr @luacmartins is this featured behind a beta? Wondering if we can demote. And can I assign y'all to work on the fix?

[luacmartins]

We can demote this since it's available only on isPolicyExpenseChatEnabled = true policies. I can take this on with @ArekChr

[situchan]

Upon checking the crash log, this looks to be the same root cause as #38379 (comment)

[luacmartins]

Discussed this one internally and we actually wanna deselect all categories when we're editing one. PR up - #38416

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Unselect all categories when editing #38416

If no regressions arise, payment will be issued on 2024-03-26. 🎊

[luacmartins]

Gonna close this one since it was a regression from #38379 (comment) and no payment is due.

[ishpaul777]

hii @luacmartins I reviewed the PR #38416 can you please repopen for payment 🙇

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

Oh sorry, missed that one. Reopening to process payment

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0197c3d60db95d1c51

[melvin-bot]

Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.

[miljakljajic]

@ishpaul777 please accept the upwork offer!

[miljakljajic]

paid!