[HOLD for payment 2024-03-19] Clicking on invite link for the second time via chat does not open All workspaces

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating PR : #37525

Version Number: 1.4.49-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Precondition:

• The invite link to workspace is https://staging.new.expensify.com/workspace/<Workspace_ID>/join?email=<admin_email>

1. Go to staging.new.expensify.com as non-member.
2. Paste the invite link in any chat (or have someone share the link via chat).
3. Click on the invite link.
4. Return to chat.
5. Click on the invite link again.

Expected Result:

User will be redirected to All worksapces page.

Actual Result:

A different chat opens when clicking on the invite link for the second time.
This issue also occurs when user opens invite link to another workspace after opening the first invite via chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6406707_1709888302000.20240308_165152.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@iwiznia I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

[garrettmknight]

I don't think this needs to be a blocker. This issue is actively being built and not in the hands of users. I'll defer to @iwiznia on whether it needs to be Internal or not though.

[narefyev91]

Will take it

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix correct redirects from chats to workspaces page #37968

If no regressions arise, payment will be issued on 2024-03-19. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@iwiznia] The PR that introduced the bug has been identified. Link to the PR:
• [@iwiznia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@iwiznia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[garrettmknight]

@narefyev91 do you have any tests for this made up or do you think we need to add one?

[narefyev91]

@narefyev91 do you have any tests for this made up or do you think we need to add one?

It was some missing functionality - i will say no other interaction needed here

[garrettmknight]

Cool, closing