[HOLD 305057] [Track Tax] - Selection highlight remains at previous default tax rate when the default rate changes

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating PR : #36784

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has some tax options.

1. [Employee] Go to workspace chat.
2. [Employee] Open request money page > Manual.
3. [Employee] Enter amount and proceed to confirmation page.
4. [Employee] Click Show more > Tax rate.
5. [Admin] On Old Dot, change the default workspace tax rate.

Expected Result:

The selection highlight will move when the default tax rate changes.

Actual Result:

The selection highlight remains at the previous default tax rate when the default rate changes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6395231_1709112005217.bandicam_2024-02-28_03-18-56-373.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@slafortune I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax - Selection highlight remains at previous default tax rate when the default rate changes

What is the root cause of that problem?

We don't have any logic to update the focus index when initiallyFocusedOptionKey gets updated. We already update the initiallyFocusedOptionKey when default tax rate changes.

App/src/components/TagPicker/index.js

Line 58 in bee752a

const selectedOptionKey = lodashGet(_.filter(lodashGet(sections, '[0].data', []), (policyTag) => policyTag.searchText === selectedTag)[0], 'keyForList');

What changes do you think we should make in order to solve the problem?

We need to implement a logic to update the focusedIndex when initiallyFocusedOptionKey gets changed.

Example:

    const prevInitialKey = usePrevious(props.initiallyFocusedOptionKey);
    useEffect(() => {
        if (prevInitialKey === props.initiallyFocusedOptionKey) {
            return;
        }
        const indexOfInitiallyFocusedOption = _.findIndex(allOptions, (option) => option.keyForList === props.initiallyFocusedOptionKey);
        setFocusedIndex(indexOfInitiallyFocusedOption);
    }, [props.initiallyFocusedOptionKey, allOptions, prevInitialKey]);

We can also add a flag to only run above useEffect in specific cases like this.

Result

update_tax_highlight.mp4

[MonilBhavsar]

Feature is WIP, so we can put this HOLD until we finish the implementation as it is being rolled out in phases https://github.com/Expensify/Expensify/issues/305057

[slafortune]

I'll move this to weekly in the meantime.

[slafortune]

PR is being reviewed - 33927

[slafortune]

Still on hold

[slafortune]

Still on hold

[trjExpensify]

The likelihood of someone running into this is in practice is so unlikely. You'd have to be creating an expense and pausing on the tax input selector exactly at the time someone on the workspace settings edits the default. @MonilBhavsar if you haven't easily solved this in a PR that's coming for Track Tax, I'd close this.