[HOLD for payment 2024-03-14] Gesture to hide the search page should be right to left

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-14
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709024846036369

Action Performed:

1. Open the search page
2. Use gesture to hide the page swiping left to right
3. Observe the animation

Expected Result:

The gesture to hide a page that opens from left to right should be a swipe from right to left OR
The search page & workspace switcher use the same direction of the profile page.

Actual Result:

We use the gesture left to right to close the "search" but the animation is from right to left

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1709067741.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ac67e098881d1f63
• Upwork Job ID: 1762586657702166528
• Last Price Increase: 2024-02-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ac67e098881d1f63

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[twisterdotcom]

Weird react navigation bug I assume. We should match the animation.

[youssef-lr]

I think @kirillzyusko is looking into this

[kirillzyusko]

@youssef-lr It should be fixed in latest build, I think (1.4.44-4 and above)

Can someone please check it and confirm? 👀

[Gajendra-Gupta]

Page should open and close like profile page right?

[melvin-bot]

📣 @Gajendra-Gupta! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[youssef-lr]

@kirillzyusko nope this is still an issue :(

[kirillzyusko]

@youssef-lr I don't think it was a regression, because PR with native stack was fully reverted

So what I want to say is that most likely this bug existed for long time and it's not related to my work with migration to native-stack

[youssef-lr]

@sobitneupane I took care of reviewing this one as it's pretty simple.

[twisterdotcom]

@youssef-lr do we need to assign @kirillzyusko here, or is it not necessary?

[youssef-lr]

No need @twisterdotcom, Kiryl is from Margelo.

[twisterdotcom]

Okay great, my favourite /app issues are ones like this. We'll just close once it's hit prod.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: gesture direction for left modal stack #37601

If no regressions arise, payment will be issued on 2024-03-14. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Determine if we should create a regression test for this bug.
• [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[twisterdotcom]

No payment necessary here. @youssef-lr do we ned a test case at all? Gonna close, but if you think we do, lay out the steps and I'll create one.

[youssef-lr]

Nah I don't think we do.