[HOLD for payment 2024-03-07] [$500] Chat - The selected 2nd contact is shown in first line

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.44
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4346886
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap on a report
3. Enter @
4. Select here from user suggestions
5. Tap enter key and go to next line
6. Enter @ and select any contact from user suggestion
7. Note, the selected 2nd contact is shown in first line
8. Send the message
9. Note here message is not highlighted

Expected Result:

Selecting user suggestions here and then another contact, must show 2nd contact at second line in compose box and after sending message, here must be highlighted

Actual Result:

Selecting user suggestions here and then another contact, showing 2nd contact at first in compose box and after sending message, here is not highlighted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393498_1708997911772.scl.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0104f679d006807363
• Upwork Job ID: 1762301377508782080
• Last Price Increase: 2024-02-27

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0104f679d006807363

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[youssef-lr]

Looks like this is caused by #36792, cc @dukenv0307, reverting your PR fixed it for me locally

Screen.Recording.2024-02-27.at.05.42.36.mov

[youssef-lr]

@abdulrahuman5196 @dukenv0307 can you guys take a look please?

[dukenv0307]

I'm checking it now.

[abdulrahuman5196]

Do ping me if we have a solution.

[dukenv0307]

@abdulrahuman5196 I tried this proposal's alternative and didn't get the regression as above. What do you think about this solution?

[abdulrahuman5196]

@abdulrahuman5196 I tried this proposal's alternative and didn't get the regression as above. What do you think about this solution?

@dukenv0307 Did we find the root cause of this issue? What is causing this?

[dukenv0307]

@abdulrahuman5196
In the first solution, we calculated leftString based on newLineIndex and every time we break a line, newLineIndex is recalculated, leading to wrong leftString and atSignIndex.

[abdulrahuman5196]

@abdulrahuman5196 I tried this proposal's alternative and didn't get the regression as above. What do you think about this solution?

@dukenv0307 If we need to implement the alternate solution, it would be better to do a straight revert of the offending PR to unblock staging and to avoid any new regressions from the alternate solution implementation. Since the alternate solution is a different implementation and would need to discuss on that.

@youssef-lr what do you think?

[dukenv0307]

leading to wrong leftString and atSignIndex.

@abdulrahuman5196 On second thought, I saw that atSignIndex is wrong because the left string is cut off from the last break line index meanwhile atSignIndex is the index based on the full string so with my main solution we need to update atSignIndex correctly by adding it with newLineIndex + 1. What do you think about this?

[abdulrahuman5196]

leading to wrong leftString and atSignIndex.

@abdulrahuman5196 On second thought, I saw that atSignIndex is wrong because the left string is cut off from the last break line index meanwhile atSignIndex is the index based on the full string so with my main solution we need to update atSignIndex correctly by adding it with newLineIndex + 1. What do you think about this?

@dukenv0307
Got it. Seems to be good. Can we raise a quick PR on the same?
And do check if any other properties need to be updated?

[dukenv0307]

Thanks, I will raise the PR after a few hours.

[dukenv0307]

@abdulrahuman5196 this PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: logic get sign index suggestion mention #37308

If no regressions arise, payment will be issued on 2024-03-07. 🎊

For reference, here are some details about the assignees on this issue:

• @mkhutornyi requires payment (Needs manual offer from BZ)

[abdulrahuman5196]

No payment required here since it was a regression fix. @youssef-lr We can close this issue.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @mkhutornyi paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1762301377508782080/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abdulrahuman5196]

No payment required here since it was a regression fix. youssef-lr We can close this issue.

cc: @trjExpensify