[HOLD for payment 2024-04-05] Chat - Video does not resume playing after regaining internet connection

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to chat
3. Upload a video
4. Go offline after upload is complete
5. Play the video
6. Go online
7. Note that it loads infinitely
8. (Web and desktop app only) Open the video in full screen
9. Note that it loads
10. Return to chat view

Expected Result:

In Step 6, after returning online, the video should load without issue
In Step 10, the video in the chat view will play because it loads successfully in Step 8

Actual Result:

In Step 6, after returning online, the video still loads infinitely
In Step 10, the video in the chat view does not load

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385632_1708430500983.bandicam_2024-02-20_14-41-24-977.mp4

View all open jobs on GitHub

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[mountiny]

I do feel like this is a new feature and it would not have to be a deploy blocker @francoisl

[kowczarz]

Hey! I will take a look on it, but I agree with @mountiny, the mentioned PR didn't introduce regression since it's a new feature and I think #36906 is a similar case.

[mountiny]

@kowczarz any updates

[Skalakid]

Hey, I will continue @kowczarz's investigation and take a look on it :D

[melvin-bot]

@eVoloshchak, @mountiny, @Skalakid, @kowczarz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Skalakid]

Hi, I investigated the issue and created a fix for it #37674. The problem is probably connected to expo-av implementation, however we can simply fix it by forcing video player to restart video loading by changing its uri inside

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix video not loading after regaining internet connection #37674

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @Skalakid does not require payment (Contractor)
• @kowczarz does not require payment (Contractor)

[mountiny]

I beelive we can close this one now

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: this is a problem with expo-av implementation
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, we already have the following item in PR reviewer checklist: I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

Regression Test Proposal

1. Navigate to staging.new.expensify.com
2. Go to chat
3. Upload a video
4. Go offline after the upload is complete
5. Play the video
6. Go online
7. Verify that the video loads
8. (Web and desktop app only) Open the video in full screen
9. Verify that the video loads

Do we agree 👍 or 👎

[eVoloshchak]

@mountiny, I forgot to finish this one, could you post a payment summary please?