[$500] iOS - Chat - Action menu does not appear when tap and hold on a video

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Pre-requisite: the user should be logged in.

1. Go to any chat.
2. Send a video.
3. Tap and hold on the video (the preview).
4. Verify no action menu appears.
5. Tap and hold on the video message background.
6. Verify the action menu appears.

Expected Result:

The action menu should appear when the user taps and hold on the video preview.

Actual Result:

The action menu does not appear when the user taps and hold on a video

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6385362_1708409277825.Vid_20240220_011332.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016bdbb68aaf6fa7d2
• Upwork Job ID: 1759899792068534272
• Last Price Increase: 2024-02-20
• Automatic offers:
• tienifr | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016bdbb68aaf6fa7d2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-vsb
CC @quinthar

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The action menu does not appear when the user taps and hold on a video

What is the root cause of that problem?

We're not having the long press handler for video thumbnail (here) like we do for image thumbnail (here), so longPress on the video thumbnail will only trigger the onPress action, it will not open the context menu which has to be handled explicitly.

What changes do you think we should make in order to solve the problem?

Add long press handler for video thumbnail like we do for image thumbnail here by using the showContextMenuForReport and ShowContextMenuContext.Consumer. This is the same approach used for pretty much all report action items type.

What alternative solutions did you explore? (Optional)

NA

[iwiznia]

Solution sounds good, so let's implement it, but do you know how this broke right now? I see the code you are proposing to modify has not changed in quite a bit, so how is this working on production?

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[saddiqueasad1]

Ensure that the tap and hold gesture is correctly configured for the video component. If you're using react-native-gesture-handler, double-check the setup for LongPressGestureHandler or equivalent,e..g:

<LongPressGestureHandler
  onHandlerStateChange={({ nativeEvent }) => {
    if (nativeEvent.state === State.ACTIVE) {
      // Your logic to open action menu
    }
  }}
  // ... other props
>
  <Video
    // ... your video props
  />
</LongPressGestureHandler>

[melvin-bot]

📣 @saddiqueasad1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[saddiqueasad1]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/asadsiddique

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[iwiznia]

Ohhhh wait.... the code was old but it was just merged! @tienifr please hold on sending the PR. I think I will either revert the video PR OR ask the author to do it.

[iwiznia]

Posted here https://expensify.slack.com/archives/C01GTK53T8Q/p1708443084946829 we might revert #30829

[tienifr]

Ohhhh wait.... the code was old but it was just merged! @tienifr please hold on sending the PR. I think I will either revert the video PR OR ask the author to do it.

@iwiznia Sorry since this is a deploy blocker, I rushed to work on it and had the changes ready locally and did the thorough testing after getting the assignment 😢 Would appreciate if I can continue with it.

[iwiznia]

ok no worries

[tienifr]

Working now.

[tienifr]

PR ready for review #36940.

[abekkala]

cherry picked to staging

[tienifr]

@abekkala Can you proceed payment for this issue? PR was on production 2 weeks ago.

[abekkala]

PAYMENT SUMMARY:

• Fix: @tienifr [$500] Offer
• PR Review: @sobitneupane [$500] Payment in NewDot

[tienifr]

@abekkala I’ve accepted the offer, thanks!

[abekkala]

@tienifr payment sent and contract ended - thank you! 🎉

[JmillsExpensify]

$500 approved for @sobitneupane based on summary.