[HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Web - Report - Blank Concierge report is displayed on back navigation from search page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.38.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Sign up with a new account
2. Click on search bar
3. Click back button

Expected Result:

Concierge report should be opened and report shouldn't be blank

Actual Result:

Blank Concierge report is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6370432_1707315855833.screen_recording_2024-02-07_at_2.43.00_in_the_afternoon.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #vip-vsb
CC @quinthar

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank Concierge report is displayed on back navigation from search page

What is the root cause of that problem?

We don't have onBackBuuttonPress prop passed to HeaderWithBackButton

App/src/pages/SearchPage/index.js

Line 149 in fc4a44f

<HeaderWithBackButton title={translate('common.search')} />

What changes do you think we should make in order to solve the problem?

Update HeaderWithBackButton to the following

<HeaderWithBackButton
                        title={translate('common.search')}
                        onBackButtonPress={Navigation.goBack}
                    />

What alternative solutions did you explore? (Optional)

N/A

[situchan]

regression from #35058
cc: @lukemorawski

[tgolen]

@lukemorawski Is this something you will be able to fix ASAP?

[situchan]

The root cause is same as other holding issues like #35965, #35969
@trjExpensify should we hold this as well?

[tgolen]

Yeah, I think we should. I'll put this on HOLD.

[situchan]

cc: @adamgrzybowski to put in your PR

[trjExpensify]

Makes sense! @adamgrzybowski let us know if you disagree though.

[hayata-suenaga]

this issue might be partially related to the issue on which Adam is working on.

instead of closing this, I'll keep this issue open with HOLD as Tim suggested.

[tgolen]

Dropping to a daily while this is on HOLD

[lukemorawski]

proposal from @GandalfGwaihir fixes on the issue on the SearchPage. I can post quick PR for that.

[allgandalf]

either ways @lukemorawski , i am also available to work on this issue with you :), paid or unpaid doesn’t really matter :)

[lukemorawski]

@GandalfGwaihir awesome. I would very thankful if you could post that quick fix. Seem like a bigger thing just popped in for me :)

[allgandalf]

yes sure, should i wait until this be assigned to me first or should i drop the PR right away?

[lukemorawski]

No idea @tgolen ⬆️ ?

[Julesssss]

Hi @lukemorawski please raise the PR now, I'll review it.

[Julesssss]

Ah sorry, I was confused. @GandalfGwaihir would be able to raise the PR?

[mountiny]

@lukemorawski Just to be clear, there should not really be bigger things than deploy blockers from PRs you have authored. This should be your top priority so we can unblock deploy.

[lukemorawski]

@mountiny Got ya! @GandalfGwaihir will post that PR!

[allgandalf]

I can help if it’s an option over here :), but again this is a deploy blocker so don’t know the feasibility of this option

[adamgrzybowski]

Hey, checkout this PR #36050 I think it should be fixed

[Julesssss]

Hey, checkout this PR #36050 I think it should be fixed

Thanks for sharing. But as we're going to have to cherry-pick any fix to staging I'm a bit hesitant to rely on that relatively complex PR.

I'd much rather stick to the simpler PR raised by @lukemorawski here.

[Julesssss]

Fix CP'd to staging. I updated the checklist and removed the blocker label.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] SearchPage back button issue fix #36141

If no regressions arise, payment will be issued on 2024-02-15. 🎊

[mountiny]

No payments required

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] SearchPage back button issue fix #36141

If no regressions arise, payment will be issued on 2024-02-19. 🎊