[HOLD for payment 2024-06-06] [$500] There's a lot of extra space above the receipt

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: V1.4.37-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @amyevans
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707179218830079

Action Performed:

1.Initiate a request money by scanning a receipt
2.Tap the preview

Expected Result:

No extra space above the receipt image

Actual Result:

There's a lot of extra space above the receipt

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

RPReplay_Final1707237277.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01afdff2fbe1dee085
• Upwork Job ID: 1754909179622940672
• Last Price Increase: 2024-02-20

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01afdff2fbe1dee085

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[parthvaghani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There's a lot of extra space above the receipt

What is the root cause of that problem?

https://github.com/Expensify/App/blob/main/src/styles/utils/index.ts#L727

What changes do you think we should make in order to solve the problem?

On L727 When we make marginTop 0, it is removing extra space above the receipt. that's where we should calculate height correctly and dynamically

[melvin-bot]

📣 @parthvaghani! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[parthvaghani]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani

[melvin-bot]

⚠️ Unable to store contributor details.

[parthvaghani]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani

[melvin-bot]

⚠️ Unable to store contributor details.

[parthvaghani]

Hello @m-natarajan could you please help with storing my contributor details?

[parthvaghani]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/pvaghani

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@miljakljajic, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

[shubham1206agra]

Still waiting for proposals

[parthvaghani]

@shubham1206agra Could you please assign this bug to me?

[rayane-djouah]

Previous Proposal

Proposal

Please re-state the problem that we are trying to solve in this issue.

The empty state background image is bigger than it should be.

What is the root cause of that problem?

The empty state background image does not have correct values for IMAGE_HEIGHT here (it is set to 450px for wide screens and 300px for small screens):

App/src/CONST.ts

Lines 143 to 167 in d6bd1c6

	EMPTY_STATE_BACKGROUND: {
	ASPECT_RATIO: 3.72,
	SMALL_SCREEN: {
	IMAGE_HEIGHT: 300,
	CONTAINER_MINHEIGHT: 200,
	VIEW_HEIGHT: 185,
	},
	WIDE_SCREEN: {
	IMAGE_HEIGHT: 450,
	CONTAINER_MINHEIGHT: 500,
	VIEW_HEIGHT: 275,
	},
	MONEY_OR_TASK_REPORT: {
	SMALL_SCREEN: {
	IMAGE_HEIGHT: 300,
	CONTAINER_MINHEIGHT: 280,
	VIEW_HEIGHT: 220,
	},
	WIDE_SCREEN: {
	IMAGE_HEIGHT: 450,
	CONTAINER_MINHEIGHT: 280,
	VIEW_HEIGHT: 275,
	},
	},
	},

What changes do you think we should make in order to solve the problem?

we should change IMAGE_HEIGHT to smaller values (we should ask design team for the expected image size on wide and on small screens).

What alternative solutions did you explore? (Optional)

N/A

Outdated after this

[rayane-djouah]

This may be related to #36166

[shubham1206agra]

@shawnborton Would like to combine this with other issue or keep it separate?

[rayane-djouah]

asked here https://expensify.slack.com/archives/C01GTK53T8Q/p1707755228886899?thread_ts=1707412868.737769&cid=C01GTK53T8Q

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@miljakljajic, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@miljakljajic @shubham1206agra this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@miljakljajic, @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[miljakljajic]

I think @shawnborton has confirmed we can combine these into a single issue

[shawnborton]

Yup, that's my thinking!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[miljakljajic]

Referenced this issue in the original, closing.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: There's a lot of extra space above the report actions #38449

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@shubham1206agra] Determine if we should create a regression test for this bug.
• [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: