Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-06][$500] [Simplified Collect][Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses #35705

Closed
luacmartins opened this issue Feb 2, 2024 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024

Implement this section of the Simplified Collect: Profile, Members, Categories design doc.

Issue OwnerCurrent Issue Owner: @parasharrajat
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014e6c1796715bbf98
  • Upwork Job ID: 1755659477413355521
  • Last Price Increase: 2024-02-08
@luacmartins luacmartins added Engineering Daily KSv2 NewFeature Something to build that is a new item. labels Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins
Copy link
Contributor Author

luacmartins commented Feb 2, 2024

@ArekChr can you please comment here so I can assign you to the issue?

@luacmartins luacmartins self-assigned this Feb 2, 2024
@luacmartins luacmartins moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 2, 2024
@luacmartins luacmartins changed the title WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses [Simplified Collect] [Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses Feb 2, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses [Simplified Collect][Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@ArekChr
Copy link
Contributor

ArekChr commented Feb 5, 2024

Sure, please assign me @luacmartins

Copy link

melvin-bot bot commented Feb 8, 2024

@luacmartins, @ArekChr, @jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 8, 2024
@melvin-bot melvin-bot bot changed the title [Simplified Collect][Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses [$500] [Simplified Collect][Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014e6c1796715bbf98

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
@ArekChr ArekChr mentioned this issue Feb 12, 2024
50 tasks
@ArekChr
Copy link
Contributor

ArekChr commented Feb 13, 2024

The draft PR is nearly complete. @luacmartins @jliexpensify, could you please review my latest update in the PR? The issue mentioned in comment is currently a blocker, thanks!

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2024
@trjExpensify
Copy link
Contributor

Pulled the Q out to Slack

@parasharrajat
Copy link
Member

What's the status of this issue? Looks like it is done cc: @trjExpensify

@luacmartins
Copy link
Contributor Author

luacmartins commented Feb 29, 2024

Yes, it's done. PR was deployed to production yesterday. I'll manually update the title.

@luacmartins luacmartins changed the title [$500] [Simplified Collect][Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses [HOLD for payment 2024-03-06][$500] [Simplified Collect][Categories] WorkspaceCategoriesPage: base page implementation, displaying categories and its statuses Feb 29, 2024
@trjExpensify
Copy link
Contributor

Yeah, we need to switch @parasharrajat for @rushatgabhane for the C+ tracking.

@sonialiap
Copy link
Contributor

@jliexpensify @luacmartins I have an automatic issue to issue payment for the PR that's linked to this issue. Do we need to issue one or two payments to Rushat for #36324?

@luacmartins
Copy link
Contributor Author

@sonialiap thanks for checking. We should only issue one payment for @rushatgabhane's PR review. I think we can close the internal issue in favor of this one.

@sonialiap
Copy link
Contributor

Thanks! Makes sense to keep it all in one place 👍 Closing out the other issue

@jliexpensify
Copy link
Contributor

jliexpensify commented Mar 5, 2024

Payment Summary

If this is correct, I'll remove the Upworks job. @rushatgabhane anything need to be done for the checklist?

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@JmillsExpensify
Copy link

$500 payment approved for @rushatgabhane based on summary.

@trjExpensify trjExpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 5, 2024
@jliexpensify
Copy link
Contributor

Upworks job removed, bump on @rushatgabhane for the checklist (if applicable).

@rushatgabhane
Copy link
Member

@jliexpensify it's a new feature.

So I recommend that we add the test steps in regression suite.

  1. Navigate to the workspace settings as an admin within a paid policy group.
  2. Verify that you can access the categories page.
  3. Verify that categories are listed.
  4. Confirm that you can select all categories by clicking on 'name', and deselect them by clicking on 'name' once more.
  5. Access workspace settings as a member with a paid group policy.
  6. Replace the sub-path /profile with /categories in the URL.
  7. Verify that a 'not found' screen is displayed on the central page.
  8. Repeat steps 4 through 6 as both an administrator and a member under a free policy.
  9. Confirm that you are unable to access the categories page.

Copy link

melvin-bot bot commented Mar 6, 2024

Payment Summary

Upwork Job

  • Contributor: @ArekChr is from an agency-contributor and not due payment
  • Reviewer: @rushatgabhane owed $500 via NewDot

BugZero Checklist (@jliexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1755659477413355521/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@jliexpensify
Copy link
Contributor

Payment Summary:

@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

8 participants