[HOLD for payment 2024-02-05] [HOLD for payment 2024-01-28] [HOLD for payment 2024-01-26] Request money - "Recent" and "Contacts" does not disappear when there is no relavant results

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.27-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to FAB > Request money > Manual
2. Enter amount > Next
3. Search for an invalid email
4. Search for valid email
5. Select Split

Expected Result:

In Step 4 and 5, "Recent" and "Contacts" will not appear when there is no relevant results

Actual Result:

In Step 4 and 5, "Recent" and "Contacts" does not disappear when there is no relevant results. This issue also occurs in Invite workspace members list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6346423_1705580107088.bandicam_2024-01-18_20-10-26-614.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lanitochka17]

#wave6-collect-submitters

[situchan]

regression from #34008

[Pujan92]

App/src/components/SelectionList/BaseSelectionList.tsx

Line 275 in 4da7fda

if (!section.title || !section.data) {

https://github.com/Expensify/App/pull/34008/files#diff-750b08e6eebe347cd7ad8d106d3ea0192256cbd6217b8a97618239ee76b3404cR275

Needs to consider the length for section.data as it is an array.

[Julesssss]

Reverting a PR to resolve this issue

[Julesssss]

Resolved with this revert PR which has been CP'd to staging.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "[TS migration] Migrate 'SelectionList' component to TypeScript" #34733

If no regressions arise, payment will be issued on 2024-01-26. 🎊

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.28-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "[TS migration] Migrate 'SelectionList' component to TypeScript" #34733

If no regressions arise, payment will be issued on 2024-01-28. 🎊

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.32-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'SelectionList' component to TypeScript #34794

If no regressions arise, payment will be issued on 2024-02-05. 🎊