Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU – An error message appears when attempting to add Amount and Merchant to IOU while scanning a receipt #34534

Closed
3 of 6 tasks
kbecciv opened this issue Jan 15, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Jan 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.25-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in as the WS employee
  3. Create scan request
  4. Open IOU while the receipt is scanning
  5. Edit the missing fields Merchant and then Amount

Expected Result:

Receipt is edited without error

Actual Result:

An error message appears when attempting to add Amount and Merchant to IOU while scanning a receipt

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image

Bug6343444_1705347688534.Error_message.1.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 15, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 15, 2024

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@roryabraham
Copy link
Contributor

roryabraham commented Jan 15, 2024

I'm currently unable to reproduce this, going to try updating Auth, Web-E, PDFs, etc...

@roryabraham
Copy link
Contributor

Yeah, I'm unable to reproduce this on main.

@roryabraham
Copy link
Contributor

Going to try reproducing locally by checking out the staging branch – maybe this has already been fixed and we just need to CP the appropriate PR?

@roryabraham
Copy link
Contributor

Yeah, not able to reproduce locally at all.

@roryabraham
Copy link
Contributor

not able to reproduce on staging either

@roryabraham
Copy link
Contributor

Given that this isn't preventing the user from completing the flow, and that it's only inconsistently reproducible, I don't think we need to block deploy on this.

@roryabraham roryabraham added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 16, 2024
Copy link

melvin-bot bot commented Jan 16, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@roryabraham
Copy link
Contributor

cc @cead22 this has to do with violations but is inconsistently reproducible. I'm trying to get more details. Slack context here

@cead22
Copy link
Contributor

cead22 commented Jan 16, 2024

This is working as designed, and it's not a bug. When you add amount or date to a money request, SmartScan is assumed to be skipped, so the violation message is correct.

Maybe we'll change how this looks visually, but this will all improve as we continue implementing violations, so closing for now

@cead22 cead22 closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants