[HOLD for payment 2024-01-25] [HOLD for payment 2024-01-24] [$250] Android - The center photo is blank in edit avatar page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to Settings > Profile
2. Tap on the avatar
3. Upload any photo

Expected Result:

The center photo is visible in edit avatar page

Actual Result:

The center photo is blank in edit avatar page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6342925_1705326692560.Screen_Recording_20240115_211537_Camera.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013bd04ea8566e3d10
• Upwork Job ID: 1746941371136151552
• Last Price Increase: 2024-01-15
• Automatic offers:
• situchan | Reviewer | 28102515
• s-alves10 | Contributor | 28102516

Issue Owner

Current Issue Owner: @conorpendergrast

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neil-marcellini]

I have to stop and drive for 1h, I'll get to this as soon as I'm back.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013bd04ea8566e3d10

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Upwork job price has been updated to $250

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Center circle image is filled with app background color instead of transparent in the avatar crop modal.

What is the root cause of that problem?

We use fill props in ImageCropView as you can see below

App/src/components/AvatarCropModal/ImageCropView.js

Line 93 in a4e3ae2

fill={theme.iconReversed}

This is the root cause

What changes do you think we should make in order to solve the problem?

Simply removing fill props would solve the issue

Result

What alternative solutions did you explore? (Optional)

[situchan]

@s-alves10 do you know which PR caused this?

[s-alves10]

@situchan I think this is reproducible in production as well. Can you take a look?

[situchan]

At least not happening on playstore app (v1.4.24-8)

[shubham1206agra]

@situchan Can you check if this is coming from RN upgrade?

[situchan]

@situchan Can you check if this is coming from RN upgrade?

I have no way to check quickly since android build takes time.
Removing fill works well but asked here for confirmation

[shubham1206agra]

I am the author there. We cannot remove fill there actually. But I am confused why fill will cause this problem.

[s-alves10]

@shubham1206agra Why do you think we should not remove fill? Can you please explain a bit?

Also please check this issue expo/expo#21530 (comment)
cc @situchan

[shubham1206agra]

@s-alves10 See https://github.com/Expensify/App/pull/33607/files#r1452637167

[situchan]

We applied patch to fix expo/expo#21530

[shubham1206agra]

If you confirm the root cause to be RN upgrade, best solution would be to downgrade expo-image.

[Pujan92]

I am not able to reproduce it.
Version - v1.4.25-2 Develop

[mountiny]

@s-alves10 @situchan Can you confirm this is fixed on the latest Android staging? I dont have android device

[situchan]

Please share android staging apk. Android is the only platform we don't have access for staging build.

[mountiny]

@situchan confirmed the fix on android

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: remove fill props from Icon in ImageCropView #34530

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Reviewer)
• @s-alves10 requires payment automatic offer (Contributor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: remove fill props from Icon in ImageCropView #34530

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Reviewer)
• @s-alves10 requires payment automatic offer (Contributor)

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[neil-marcellini]

@conorpendergrast would you please handle payment here?

[conorpendergrast]

Gladly!

[conorpendergrast]

Payouts due:

• Contributor: $250 @s-alves10 - Contract
• Contributor+: $250 @situchan - Contract

Upwork job is here.

[conorpendergrast]

This was caught in a regression test by Applause, but I don't see that we have a clear idea of where this regression happened.

@situchan thoughts?

[situchan]

This came from expo-image upgrade. It was upstream issue which couldn't be handled by us.
The issue won't likely to be happen in the future once we settle the expo version which fixes all these image related issues.

[conorpendergrast]

Alright, sounds good. Closing out, thanks!