[HOLD for payment 2024-01-24] [HOLD PR #33863][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Inernal Team
Slack conversation:

Action Performed:

1. Login to ND Expensify
2. Navigate to account settings
3. Hover over each of the options
4. Verify if Expensify icon of "Go to Expensify Classic" option turn to white when hover

Expected Result:

Expensify icon of "Go to Expensify Classic" option should turn to white color when hover (or black color in light theme)

Actual Result:

Expensify icon of "Go to Expensify Classic" option doesn't turn to white color when hover (or black color in light theme)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324269_1703272807471.2023-12-22_21-38-51.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b5dbb083b2a8f016
• Upwork Job ID: 1738279174350815232
• Last Price Increase: 2023-12-29

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b5dbb083b2a8f016

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

For 'Go to expensify classic' menu item, Icon color is not changing on hover

What is the root cause of that problem?

Currently, static color has been set for fill prop in the svg file.
https://github.com/Expensify/App/blob/main/assets/images/new-expensify.svg?short_path=38276ec#L1C161-L1C161

It is added in this PR.

What changes do you think we should make in order to solve the problem?

We need to remove this fill attribute from the svg file and allow the IconComponent to fill dynamic value.
Not related to fixing this issue but we can also add the same class prop .st1{fill-rule:evenodd;clip-rule:evenodd} which we have for other svgs file.

[paultsimura]

The original issue #32875 is still on the regression period, so this issue should be handled as a follow-up.
cc: @barttom @thesahindia

[NoumanHunzai]

**Proposal to Resolve SVG Icon Color Change Issue:

Proposed Solution:**
Update the SVG style rule from:
.st1 { fill: #03d47c; }

to

.st1 { fill-rule: evenodd; clip-rule: evenodd; }

Verification:
A video demonstrating the successful implementation is available
https://www.loom.com/share/a807263b9c4444b58c7d0e69286dffff?sid=15696b45-109b-43e0-9040-8e6ba8a01866

Description of Logic:
The addition of fill-rule: evenodd; and clip-rule: evenodd; in the SVG styling simplifies and unifies the color change behavior.

fill-rule: evenodd;:
This makes sure that when coloring the shape, a point is considered inside if it crosses the boundary an odd number of times and outside if it's even.

clip-rule: evenodd;:
Similarly, when clipping the element, areas crossed an odd number of times remain visible, while those crossed an even number of times are hidden.

Why It Matters:
By using the same even-odd logic for both filling and clipping, we ensure a consistent and visually pleasing hover effect on the SVG icon.

Thank You

[melvin-bot]

📣 @NoumanHunzai! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[NoumanHunzai]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01cc5e42206c63e202

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@eVoloshchak, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@eVoloshchak, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @miljakljajic 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@eVoloshchak, @miljakljajic 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[pecanoro]

@miljakljajic This should be fixed when 33863 gets merged since it was coming from a different issue. Once that gets deployed, please simply check if it's reproducible and close it if it is fixed!

[miljakljajic]

Thank you, will do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/32875/svg color and olddot url #33863

If no regressions arise, payment will be issued on 2024-01-24. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

Not reproducible any more - closing as per Rocio's comment above.