[HOLD for payment 2024-01-24] Settings - 'Go to Expensify Classic' options redirect to prod, not STG version

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.14-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/r/88085227
2. Login with any account
3. Go to Settings -> Go to Expensify Classic

Expected Result:

The system redirects to the staging version of OldDot

Actual Result:

The system redirects to the production version of OldDot

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6319515_1702988818808.bandicam_2023-12-19_12-00-33-072.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Go to Expensify Classic' options redirect to prod, not STG version

What is the root cause of that problem?

We have defined the production link for the action in the app:

App/src/pages/settings/InitialSettingsPage.js

Lines 268 to 272 in aa1d87c

	translationKey: 'initialSettingsPage.goToExpensifyClassic',
	icon: Expensicons.NewExpensify,
	action: () => {
	Link.openExternalLink(CONST.EXPENSIFY_INBOX_URL);
	},

What changes do you think we should make in order to solve the problem?

We should update the EXPENSIFY_INBOX_URL to point to staging:

App/src/CONST.ts

Line 473 in aa1d87c

EXPENSIFY_INBOX_URL: 'https://www.expensify.com/inbox',

EXPENSIFY_INBOX_URL: 'https://www.staging.expensify.com/inbox',

Alternatively:

We can add a another key EXPENSIFY_INBOX_STG_URL to point to staging to keep both the links in app.

We may then also change the current one to EXPENSIFY_INBOX_PROD_URL

We'll be updating all mentions of the key in the app,

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We are using the hard-coded prod URL in the menu item:

App/src/pages/settings/InitialSettingsPage.js

Lines 267 to 272 in aa1d87c

	{
	translationKey: 'initialSettingsPage.goToExpensifyClassic',
	icon: Expensicons.NewExpensify,
	action: () => {
	Link.openExternalLink(CONST.EXPENSIFY_INBOX_URL);
	},

What changes do you think we should make in order to solve the problem?

We shouldn't use the constant URL, but instead use the Link.buildOldDotURL('inbox'):

{
                translationKey: 'initialSettingsPage.goToExpensifyClassic',
                icon: Expensicons.NewExpensify,
                action: () => {
                    Link.openOldDotLink('inbox');
                },
                shouldShowRightIcon: true,
                iconRight: Expensicons.NewWindow,
                link: Link.buildOldDotURL('inbox'),
            },

What alternative solutions did you explore? (Optional)

[situchan]

This is not deploy blocker as new feature and should work fine on production.
cc: @barttom as coming from #32947

[melvin-bot]

@srikarparsi Huh... This is 4 days overdue. Who can take care of this?

[srikarparsi]

I believe @barttom is fixing this. Will take a look back towards the beginning of next week if there's no update

[srikarparsi]

^

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/32875/svg color and olddot url #33863

If no regressions arise, payment will be issued on 2024-01-24. 🎊

[srikarparsi]

oh hold for payment

[srikarparsi]

on hold

[srikarparsi]

Was fixed here and I made sure that this is no longer reproducible. Closing this out since it was handled by an external agency which I don't believe requires payment. But if it does, please reopen this issue or tag me.