[HOLD for payment 2024-01-25] [$500] [Wave 6: Workspace Chats] IOU - Chat with IOU shows "This is beginning" in LHN after login and no Pay elsewhere in IOU preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.9-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User has received IOU request

1. Log out
2. Log in
3. Open the chat with IOU request

Expected Result:

The chat preview in LHN will show the latest IOU action
After opening the chat, the IOU preview shows Pay elsewhere

Actual Result:

The chat preview in LHN shows "This is the beginning of" instead of the latest IOU action
After opening the chat, the IOU preview does not show Pay elsewhere unless the IOU report is visited and user returns to the main chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6304418_1701953266666.20231207_160647.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ff0e7b70f9f8b4d4
• Upwork Job ID: 1732753199542329344
• Last Price Increase: 2023-12-07
• Automatic offers:
• cubuspl42 | Reviewer | 28080970
• paultsimura | Contributor | 28080971

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ff0e7b70f9f8b4d4

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After login, the report previews. are displayed incorrectly.

What is the root cause of that problem?

This seems like a BE issue: on the OpenApp request, only chat reports are loaded. As a result, the ReportPreview actions show invalid data, since the IOU Reports are absent from Onyx.
This might be a side-effect of #29593

What changes do you think we should make in order to solve the problem?

This should be fixed on the BE side by either loading all the accessible reports on OpenApp, or by modifying the OpenReport API response to return not only the requested report but also all the associated IOU Reports (or even all the child reports).

To fix this solely on the FE side, we can add an OpenReport call on the ReportPreview actions if the IOU reports are missing. This will fetch the report from BE once the report action is mounted:

    useEffect(() => {
        if (lodashHas(props.iouReport, 'reportID')) {
            return;
        }

        Report.openReport(props.iouReportID);
    }, []);

What alternative solutions did you explore? (Optional)

[cubuspl42]

@paultsimura Thank you for investigating this!

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[cubuspl42]

@thienlnam Would you give it a look?

[melvin-bot]

Current assignee @cubuspl42 is eligible for the Internal assigner, not assigning anyone new.

[trjExpensify]

CC: @puneetlath @rezkiy37 @situchan as well for the hunch it might be related to #29593

[rezkiy37]

CC: @puneetlath @rezkiy37 @situchan as well for the hunch it might be related to #29593

AFAIK, we didn't touch policy expense report chats.

[trjExpensify]

This looks like it's a preview of an iouReport inside a DM. Not a preview of an expenseReport inside a policyExpenseChat (A.K.A "workspace chat").

[puneetlath]

Adding this to the wave6 project as critical so that someone can investigate. cc @greg-schroeder

[melvin-bot]

@cubuspl42, @yuwenmemon, @paultsimura, @trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[paultsimura]

Thanks. The PR is ready for review: #33981

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: use lazy loading for the IOU Report previews #33981

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Reviewer)
• @paultsimura requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 checklist time ahead of tomorrow!

[cubuspl42]

• The PR that introduced the bug has been identified. Link to the PR:
  • Refactor fetchAllReports in App init #10051
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • https://github.com/Expensify/App/pull/10051/files#r1466239591
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • No need for additional discussion
• Determine if we should create a regression test for this bug.
  • Up to the QA team
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • Ensure that you have a 1:1 chat report where an IOU Preview is the last action
  • Log out
  • Log in
  • Verify that the summary text in the LHN for the mentioned report is "{userDisplayName} owes {amount}"

[cubuspl42]

@paultsimura believe that the "QA Steps" in your PR weren't up-to-date when we merged. My oversight. What do you think of the steps I suggested above?

[paultsimura]

"QA Steps" in your PR weren't up-to-date when we merged

@cubuspl42 I was working on the PR for this issue. Are we talking about this one, or there's another? 🤔

[cubuspl42]

Sorry, I had Bernard's PR open in another tab and I confused usernames

[paultsimura]

Log out
Log in
Open a chat with an IOU Report (but don't open the IOU Report itself).
Verify that the report shows a correct message of "{user} owes {amount}" format in LHN

These are the steps from my PR. It's pretty similar to the ones you've added IMO. Would you prefer me to change it anyway?

[cubuspl42]

I'm just confirming that the latest are correct. In the one you quoted, we don't focus on the fact that IOU has to be the last item in the chat log. But I guess that updating the QA Steps on the PR wouldn't hurt 🤷‍♂️

[paultsimura]

Oh, I missed that, thanks. Updated now.

[trjExpensify]

Confirming payments as follows:

• $500 to @paultsimura for the fix
• $500 to @cubuspl42 for the review.

[trjExpensify]

Settled up!