[HOLD for payment 2024-01-30] [HIGH] Workspace Chats: Submitting report offline causes errors in the report and red dot w/o error message in LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.6.2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #32157

Action Performed:

Precondition:

• User is an employee of a Collect workspace

1. Log in to ND as the employee
2. Go offline
3. Go to the workspace chat > + > Request money
4. Create a manual request with currency different than the workspace default currency
5. Open expense report and submit the expense
6. Return online

Expected Result:

The report will be submitted without issue when returning online

Actual Result:

Three issues show up

1. The report submission message moves above the report chat view
2. Submit button appears again when returning online
3. In LHN, the expense report shows a red dot but there is no error message in the report. The red dot remains after clicking Submit button again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6296270_1701364502503.20231130_234446.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kadiealexander

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

I'm inviting a user to a collect workspace as an employee and the workspace expense chat isn't showing up for the employee in the LHN or as an option to request money from. Is there a beta that I'm missing?

[jasperhuangg]

Clarified that this isn't a deploy blocker here

Reasoning is that it's behind a beta and we are still going to work on this so it should just be added to the wave6 project

[jasperhuangg]

Assigning @mountiny since this was related to his PR

[mountiny]

So this is a known limitation right now, we do not know the managerID on the open expense report when its created optimistically.

[mountiny]

thats why the submission offline fails because we "did not submit to anyone". Was discussed in slack in previous days and we will have to pass down who we need to submit to as part of the Policy data

[mountiny]

Discussin gin Slack, we will probably update the nedpoint to not require the manager Account Id as that is not needed for the submitter to know

[mountiny]

On the list for this week

[mountiny]

I will create a new SubmitExpenseReport command for this and that will not require passing the accountID

[mountiny]

Continuing to work on this today

[melvin-bot]

@mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @michaelhaxhiu you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @aimane-chnaif paid $500 via Upwork (offer)

BugZero Checklist (@kadiealexander)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[mountiny]

$500 to @aimane-chnaif for review and testing

[kadiealexander]

Please request your payment via NewDot @aimane-chnaif.

[aimane-chnaif]

@kadiealexander I am yet using upwork. Can you please reopen?

[melvin-bot]

@mountiny, @kadiealexander, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

Ah sorry @aimane-chnaif I misunderstood. I've sent you a contract :)

[kadiealexander]

@aimane-chnaif please let me know when you've accepted the offer!

[aimane-chnaif]

@kadiealexander accepted thanks

[melvin-bot]

@mountiny, @kadiealexander, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

Paid!