Bank account - Error returns when input is entered in phone number, Tax ID and SSN fields

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.1-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30568

Action Performed:

Bug 1: Phone number and Tax ID field

1. Navigate to staging.new.expensify.com
2. Go to Settings > Workspaces > any workspace
3. Go to Bank account
4. Click Connect manually
5. Proceed to Company information
6. Click Phone number field and enter a phone number
7. Click on the Tax ID field

Bug 2: SSN field
Precondition: Have a bank account added

1. Navigate to staging.new.expensify.com
2. Go to Settings > Wallet
3. Click Enable Wallet
4. Click on the SSN field
5. Enter a value

Expected Result:

The field will not return validation error when the input is not completed

Actual Result:

The phone number field returns validation error as soon as value is entered.
Tax ID and SSN fields show error as soon as the input field is focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6284198_1700503510349.Phone_number_and_Tax_ID.mp4

Bug6284198_1700503510334.SSN_field.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Error returns when input is entered in phone number, Tax ID and SSN fields

What is the root cause of that problem?

We are validating Form when input change

What changes do you think we should make in order to solve the problem?

Should pass shouldValidateOnChange: false to FormProvider in CompanyStep Page

What alternative solutions did you explore? (Optional)

[roryabraham]

I don't think this is a bug

[situchan]

I think this is against Form guideline.
cc: @luacmartins

https://github.com/Expensify/App/blob/main/contributingGuides/FORMS.md#validate-on-blur-on-change-and-submit

Once a user has “touched” an input, i.e. blurred the input, we will also start validating that input on change when the user goes back to editing it.

But input is not "touched" yet.