-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-20] [HOLD for payment 2023-12-12] [Tracking] Use measureFunction from reassure to cover performance testing of important functions #30569
Comments
this is being worked on |
Making a steady progress 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
|
@OlimpiaZurek @adhorodyski This is all done, right? |
Hey @mountiny perf tests for methods from |
@mountiny PR is ready for review |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
|
Seems like we are all done here! |
Coming from here https://expensify.slack.com/archives/C05LX9D6E07/p1698193710179789
We have set up the reassure in the App with new option to use
measureFunction
to test performance of methods. Lets use this to cover the most crucial method in the app to ensure changes do not introduce big regressions in these methods which might already take long and are called often.Let's focus on methods in
ReportActionsUtils
,SidebarUtils
(getOptionData
specifically) andReportUtils
The text was updated successfully, but these errors were encountered: